From 2e3a273b5374635d66459115318aadd40b13f7d0 Mon Sep 17 00:00:00 2001 From: "info@eWallah.net" Date: Tue, 30 Jan 2024 15:22:53 +0100 Subject: [PATCH 1/2] MDL-80538 phpdoc: Incorrect dataformat type documentation in table lib --- lib/tablelib.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/tablelib.php b/lib/tablelib.php index 712c8b505cd..2283fcd62d2 100644 --- a/lib/tablelib.php +++ b/lib/tablelib.php @@ -220,10 +220,10 @@ class flexible_table { * for you (even if the param is '', which means no download this time. * Also you can call this method with no params to get the current set * download type. - * @param string $download dataformat type. One of csv, xhtml, ods, etc + * @param string $download type of dataformat for export. * @param string $filename filename for downloads without file extension. * @param string $sheettitle title for downloaded data. - * @return string download dataformat type. One of csv, xhtml, ods, etc + * @return string download dataformat type. */ function is_downloading($download = null, $filename='', $sheettitle='') { if ($download!==null) { From 52695bbb94612f8eaa55ea9cb1119a03eb79cf16 Mon Sep 17 00:00:00 2001 From: Simey Lameze Date: Thu, 1 Feb 2024 12:06:43 +0800 Subject: [PATCH 2/2] MDL-80538 phpdoc: add missing null parameter type to phpdoc --- lib/tablelib.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tablelib.php b/lib/tablelib.php index 2283fcd62d2..06612d7991b 100644 --- a/lib/tablelib.php +++ b/lib/tablelib.php @@ -220,7 +220,7 @@ class flexible_table { * for you (even if the param is '', which means no download this time. * Also you can call this method with no params to get the current set * download type. - * @param string $download type of dataformat for export. + * @param string|null $download type of dataformat for export. * @param string $filename filename for downloads without file extension. * @param string $sheettitle title for downloaded data. * @return string download dataformat type.