From 45c2c63e628bf1f770ccfd5302b92f9804b99d16 Mon Sep 17 00:00:00 2001 From: andelacruz Date: Tue, 13 May 2025 10:23:34 +0800 Subject: [PATCH] MDL-85279 mod_page: Fix behat to match the expected behaviour --- .../behat/page_activity_completion.feature | 27 +++++++++---------- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/mod/page/tests/behat/page_activity_completion.feature b/mod/page/tests/behat/page_activity_completion.feature index 514a12dcfa8..256d70c4003 100644 --- a/mod/page/tests/behat/page_activity_completion.feature +++ b/mod/page/tests/behat/page_activity_completion.feature @@ -14,9 +14,11 @@ Feature: View activity completion information in the Page resource | Course 1 | C1 | 0 | 1 | 1 | | Course 2 | C2 | 0 | 1 | 0 | And the following "course enrolments" exist: - | user | course | role | - | student1 | C1 | student | - | teacher1 | C1 | editingteacher | + | user | course | role | + | student1 | C1 | student | + | student1 | C2 | student | + | teacher1 | C1 | editingteacher | + | teacher1 | C2 | editingteacher | Scenario: A teacher can view a page resource automatic completion items Given the following "activity" exists: @@ -69,7 +71,7 @@ Feature: View activity completion information in the Page resource And I toggle the manual completion state of "Music history" And the manual completion button of "Music history" is displayed as "Done" - Scenario: The manual completion button will not be shown on the course page if the Show activity completion conditions is set to No as teacher + Scenario Outline: Page module manual completion button hidden if Show activity completion is set to No Given the following "activity" exists: | activity | page | | course | C2 | @@ -77,16 +79,11 @@ Feature: View activity completion information in the Page resource | name | Music history | | intro | A lesson learned in life | | completion | 1 | - When I am on the "Music history" "page activity" page logged in as teacher1 + When I am on the "Course 2" course page logged in as + # Course 2 has 'Show activity completion conditions' set to No, so the manual completion button should not be displayed. Then the manual completion button for "Music history" should not exist - Scenario: The manual completion button will not be shown on the course page if the Show activity completion conditions is set to No as student - Given the following "activity" exists: - | activity | page | - | course | C2 | - | idnumber | page1 | - | name | Music history | - | intro | A lesson learned in life | - | completion | 1 | - When I am on the "Music history" "page activity" page logged in as student1 - Then the manual completion button for "Music history" should not exist + Examples: + | user | + | teacher1 | + | student1 |