From 45a64c19bf2a38c4856de93d007c5a84375da7b4 Mon Sep 17 00:00:00 2001
From: Raymond Wijaya <raymond.wijaya@netspot.com.au>
Date: Thu, 13 Sep 2012 16:33:10 +0800
Subject: [PATCH] MDL-35436: mod_assign : Usability issues: add validation
 rules in the confirmation page for invalid grades uploaded via csv files

---
 mod/assign/feedback/offline/importgradesform.php | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/mod/assign/feedback/offline/importgradesform.php b/mod/assign/feedback/offline/importgradesform.php
index cf8f49da47a..326dc5a01b7 100644
--- a/mod/assign/feedback/offline/importgradesform.php
+++ b/mod/assign/feedback/offline/importgradesform.php
@@ -123,6 +123,11 @@ class assignfeedback_offline_import_grades_form extends moodleform implements re
             } else if ($assignment->grading_disabled($user->id)) {
                 // Skip grade is locked.
                 $skip = true;
+            } else if (!is_numeric($gradedesc) && ($assignment->get_instance()->grade) > -1) {
+                $skip = true;
+            } else if (($assignment->get_instance()->grade > -1) &&
+                      (($gradedesc < 0) || ($gradedesc > $assignment->get_instance()->grade))) {
+                $skip = true;
             }
 
             if (!$skip) {