MDL-80087 Questions: warn if preload_all_step_users was not called

Co-authored-by: Tim Hunt <[email protected]>
2024-04-25 09:37:47 +07:00
parent 6a04c121af
commit 452cf5c72d
5 changed files with 38 additions and 19 deletions
@@ -1030,9 +1030,8 @@ class question_usage_by_activity {
        // Update user information for steps.
        foreach ($this->questionattempts as $qa) {
            foreach ($qa->get_full_step_iterator() as $step) {
-                $user = $users[$step->get_user_id()];
-                if (isset($user)) {
-                    $step->add_full_user_object($user);
+                if (isset($users[$step->get_user_id()])) {
+                    $step->add_full_user_object($users[$step->get_user_id()]);
                }
            }
        }