diff --git a/admin/tool/log/tests/manager_test.php b/admin/tool/log/tests/manager_test.php index 8949f004fcf..6fb1a90b240 100644 --- a/admin/tool/log/tests/manager_test.php +++ b/admin/tool/log/tests/manager_test.php @@ -50,5 +50,22 @@ class tool_log_manager_testcase extends advanced_testcase { $this->assertInternalType('string', $key); $this->assertInstanceOf('core\log\reader', $store); } + + $stores = $manager->get_readers('core\log\sql_reader'); + $this->assertInternalType('array', $stores); + $this->assertCount(1, $stores); + foreach ($stores as $key => $store) { + $this->assertInternalType('string', $key); + $this->assertSame('logstore_standard', $key); + $this->assertInstanceOf('core\log\sql_reader', $store); + } + + $stores = $manager->get_readers('core\log\reader'); + $this->assertInternalType('array', $stores); + $this->assertCount(2, $stores); + foreach ($stores as $key => $store) { + $this->assertInternalType('string', $key); + $this->assertInstanceOf('core\log\reader', $store); + } } } diff --git a/lib/classes/log/dummy_manager.php b/lib/classes/log/dummy_manager.php index cbfb2fab535..818e9ba2fea 100644 --- a/lib/classes/log/dummy_manager.php +++ b/lib/classes/log/dummy_manager.php @@ -28,7 +28,7 @@ namespace core\log; defined('MOODLE_INTERNAL') || die(); class dummy_manager implements manager { - public function get_readers() { + public function get_readers($interface = null) { return array(); }