From 3f45006d3a28b2e3089d0edc62326bde684dcdd9 Mon Sep 17 00:00:00 2001
From: Alexander Van der Bellen <alexandervanderbellen@catalyst-au.net>
Date: Tue, 15 Jul 2025 20:59:41 +0800
Subject: [PATCH] MDL-86023 core_task: Task failures always log a stack trace

---
 lib/classes/cron.php | 24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/lib/classes/cron.php b/lib/classes/cron.php
index 25fa8e36419..120b9ec33cf 100644
--- a/lib/classes/cron.php
+++ b/lib/classes/cron.php
@@ -430,14 +430,12 @@ class cron {
             }
             mtrace('... used ' . display_size(memory_get_peak_usage()) . ' peak memory');
             mtrace('Scheduled task failed: ' . $fullname . ',' . $e->getMessage());
-            if ($CFG->debugdeveloper) {
-                if (!empty($e->debuginfo)) {
-                    mtrace("Debug info:");
-                    mtrace($e->debuginfo);
-                }
-                mtrace("Backtrace:");
-                mtrace(format_backtrace($e->getTrace(), true));
+            if (!empty($e->debuginfo)) {
+                mtrace("Debug info:");
+                mtrace($e->debuginfo);
             }
+            mtrace("Backtrace:");
+            mtrace(format_backtrace($e->getTrace(), true));
             \core\task\manager::scheduled_task_failed($task);
         } finally {
             // Reset debugging if it changed.
@@ -542,14 +540,12 @@ class cron {
             }
             mtrace('... used ' . display_size(memory_get_peak_usage()) . ' peak memory');
             mtrace("Adhoc task failed: " . get_class($task) . "," . $e->getMessage());
-            if ($CFG->debugdeveloper) {
-                if (!empty($e->debuginfo)) {
-                    mtrace("Debug info:");
-                    mtrace($e->debuginfo);
-                }
-                mtrace("Backtrace:");
-                mtrace(format_backtrace($e->getTrace(), true));
+            if (!empty($e->debuginfo)) {
+                mtrace("Debug info:");
+                mtrace($e->debuginfo);
             }
+            mtrace("Backtrace:");
+            mtrace(format_backtrace($e->getTrace(), true));
             \core\task\manager::adhoc_task_failed($task);
         } finally {
             // Reset debug level if it changed.