From 3e9dfd7f62b6a449fc8fd103efb1a280c3ec4913 Mon Sep 17 00:00:00 2001
From: Yuliya Bozhko <yuliya.bozhko@totaralms.com>
Date: Wed, 25 Jun 2014 16:57:25 +1200
Subject: [PATCH] MDL-46107 badges: Fix badges navigation and remove empty
 breadcrumbs on pages using Clean

Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>
---
 badges/badge.php                                | 11 ++++++++++-
 badges/external.php                             |  8 ++++++++
 theme/bootstrapbase/renderers/core_renderer.php |  3 +++
 3 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/badges/badge.php b/badges/badge.php
index c2f7a63300a..29f8cb43c0c 100644
--- a/badges/badge.php
+++ b/badges/badge.php
@@ -52,7 +52,16 @@ $PAGE->set_title(get_string('issuedbadge', 'badges'));
 if (isloggedin()) {
     $PAGE->set_heading($badge->badgeclass['name']);
     $PAGE->navbar->add($badge->badgeclass['name']);
-    $url = new moodle_url('/badges/mybadges.php');
+    if ($badge->recipient->id == $USER->id) {
+        $url = new moodle_url('/badges/mybadges.php');
+    } else {
+        $url = new moodle_url($CFG->wwwroot);
+    }
+    navigation_node::override_active_url($url);
+} else {
+    $PAGE->set_heading($badge->badgeclass['name']);
+    $PAGE->navbar->add($badge->badgeclass['name']);
+    $url = new moodle_url($CFG->wwwroot);
     navigation_node::override_active_url($url);
 }
 
diff --git a/badges/external.php b/badges/external.php
index f18883bf42b..1a9cee8f0dd 100644
--- a/badges/external.php
+++ b/badges/external.php
@@ -82,6 +82,14 @@ $badge = new external_badge($badge, $userid);
 
 $PAGE->set_pagelayout('base');
 $PAGE->set_title(get_string('issuedbadge', 'badges'));
+$PAGE->set_heading(s($badge->issued->assertion->badge->name));
+$PAGE->navbar->add(s($badge->issued->assertion->badge->name));
+if (isloggedin() && $USER->id == $userid) {
+    $url = new moodle_url('/badges/mybadges.php');
+} else {
+    $url = new moodle_url($CFG->wwwroot);
+}
+navigation_node::override_active_url($url);
 
 echo $OUTPUT->header();
 
diff --git a/theme/bootstrapbase/renderers/core_renderer.php b/theme/bootstrapbase/renderers/core_renderer.php
index ece81623348..1ccc13b3261 100644
--- a/theme/bootstrapbase/renderers/core_renderer.php
+++ b/theme/bootstrapbase/renderers/core_renderer.php
@@ -56,6 +56,9 @@ class theme_bootstrapbase_core_renderer extends core_renderer {
      */
     public function navbar() {
         $items = $this->page->navbar->get_items();
+        if (empty($items)) {
+            return '';
+        }
         $breadcrumbs = array();
         foreach ($items as $item) {
             $item->hideicon = true;