From d58adec8decaf7c13a8aee85f2a490a3528aae71 Mon Sep 17 00:00:00 2001 From: Ankit Agarwal Date: Thu, 16 Feb 2017 11:34:02 +0530 Subject: [PATCH] MDL-57619 behat: Final deprecation of old behat steps --- lib/tests/behat/behat_deprecated.php | 230 +-------------------------- lib/upgrade.txt | 25 +++ 2 files changed, 26 insertions(+), 229 deletions(-) diff --git a/lib/tests/behat/behat_deprecated.php b/lib/tests/behat/behat_deprecated.php index 118d89a879d..ddd1a885432 100644 --- a/lib/tests/behat/behat_deprecated.php +++ b/lib/tests/behat/behat_deprecated.php @@ -41,235 +41,6 @@ use Behat\Mink\Exception\ElementNotFoundException as ElementNotFoundException, */ class behat_deprecated extends behat_base { - /** - * @Given /^I click on "(?P(?:[^"]|\\")*)" "(?P(?:[^"]|\\")*)" in the "(?P(?:[^"]|\\")*)" table row$/ - * @deprecated since Moodle 2.7 MDL-42627 - please do not use this step any more. - */ - public function i_click_on_in_the_table_row($element, $selectortype, $tablerowtext) { - $alternative = 'I click on "' . $this->escape($element) . '" "' . $this->escape($selectortype) . - '" in the "' . $this->escape($tablerowtext) . '" "table_row"'; - $this->deprecated_message($alternative, true); - } - - /** - * @Given /^I go to notifications page$/ - * @deprecated since Moodle 2.7 MDL-42731 - please do not use this step any more. - */ - public function i_go_to_notifications_page() { - $alternative = array( - 'I expand "' . get_string('administrationsite') . '" node', - 'I click on "' . get_string('notifications') . '" "link" in the "'.get_string('administration').'" "block"' - ); - $this->deprecated_message($alternative, true); - } - - /** - * @When /^I add "(?P(?:[^"]|\\")*)" file from recent files to "(?P(?:[^"]|\\")*)" filepicker$/ - * @deprecated since Moodle 2.7 MDL-42174 - please do not use this step any more. - */ - public function i_add_file_from_recent_files_to_filepicker($filename, $filepickerelement) { - $reponame = get_string('pluginname', 'repository_recent'); - $alternative = 'I add "' . $this->escape($filename) . '" file from "' . - $reponame . '" to "' . $this->escape($filepickerelement) . '" filemanager'; - $this->deprecated_message($alternative, true); - } - - /** - * @When /^I upload "(?P(?:[^"]|\\")*)" file to "(?P(?:[^"]|\\")*)" filepicker$/ - * @deprecated since Moodle 2.7 MDL-42174 - please do not use this step any more. - */ - public function i_upload_file_to_filepicker($filepath, $filepickerelement) { - $alternative = 'I upload "' . $this->escape($filepath) . '" file to "' . - $this->escape($filepickerelement) . '" filemanager'; - $this->deprecated_message($alternative, true); - } - - /** - * @Given /^I create "(?P(?:[^"]|\\")*)" folder in "(?P(?:[^"]|\\")*)" filepicker$/ - * @deprecated since Moodle 2.7 MDL-42174 - please do not use this step any more. - */ - public function i_create_folder_in_filepicker($foldername, $filepickerelement) { - $alternative = 'I create "' . $this->escape($foldername) . - '" folder in "' . $this->escape($filepickerelement) . '" filemanager'; - $this->deprecated_message($alternative, true); - } - - /** - * @Given /^I open "(?P(?:[^"]|\\")*)" folder from "(?P(?:[^"]|\\")*)" filepicker$/ - * @deprecated since Moodle 2.7 MDL-42174 - please do not use this step any more. - */ - public function i_open_folder_from_filepicker($foldername, $filepickerelement) { - $alternative = 'I open "' . $this->escape($foldername) . '" folder from "' . - $this->escape($filepickerelement) . '" filemanager'; - $this->deprecated_message($alternative, true); - } - - /** - * @Given /^I unzip "(?P(?:[^"]|\\")*)" file from "(?P(?:[^"]|\\")*)" filepicker$/ - * @deprecated since Moodle 2.7 MDL-42174 - please do not use this step any more. - */ - public function i_unzip_file_from_filepicker($filename, $filepickerelement) { - $alternative = 'I unzip "' . $this->escape($filename) . '" file from "' . - $this->escape($filepickerelement) . '" filemanager'; - $this->deprecated_message($alternative, true); - } - - /** - * @Given /^I zip "(?P(?:[^"]|\\")*)" folder from "(?P(?:[^"]|\\")*)" filepicker$/ - * @deprecated since Moodle 2.7 MDL-42174 - please do not use this step any more. - */ - public function i_zip_folder_from_filepicker($foldername, $filepickerelement) { - $alternative = 'I zip "' . $this->escape($foldername) . '" folder from "' . - $this->escape($filepickerelement) . '" filemanager'; - $this->deprecated_message($alternative, true); - } - - /** - * @Given /^I delete "(?P(?:[^"]|\\")*)" from "(?P(?:[^"]|\\")*)" filepicker$/ - * @deprecated since Moodle 2.7 MDL-42174 - please do not use this step any more. - */ - public function i_delete_file_from_filepicker($name, $filepickerelement) { - $alternative = 'I delete "' . $this->escape($name) . '" from "' . - $this->escape($filepickerelement) . '" filemanager'; - $this->deprecated_message($alternative, true); - } - - /** - * @Given /^I send "(?P(?:[^"]|\\")*)" message to "(?P(?:[^"]|\\")*)"$/ - * @deprecated since Moodle 2.7 MDL-43584 - please do not use this step any more. - */ - public function i_send_message_to_user($messagecontent, $tousername) { - $alternative = 'I send "' . $this->escape($messagecontent) . '" message to "USER_FULL_NAME" user'; - $this->deprecated_message($alternative, true); - } - - /** - * @Given /^I add "(?P(?:[^"]|\\")*)" user to "(?P(?:[^"]|\\")*)" cohort$/ - * @deprecated since Moodle 2.7 MDL-43584 - please do not use this step any more. - */ - public function i_add_user_to_cohort($username, $cohortidnumber) { - $alternative = 'I add "USER_FIRST_NAME USER_LAST_NAME (USER_EMAIL)" user to "' - . $this->escape($cohortidnumber) . '" cohort members'; - $this->deprecated_message($alternative, true); - } - - /** - * @Given /^I add "(?P(?:[^"]|\\")*)" user to "(?P(?:[^"]|\\")*)" group$/ - * @deprecated since Moodle 2.7 MDL-43584 - please do not use this step any more. - */ - public function i_add_user_to_group($username, $groupname) { - $alternative = 'I add "USER_FULL_NAME" user to "' . $this->escape($groupname) . '" group members'; - $this->deprecated_message($alternative, true); - } - - /** - * @When /^I fill in "(?P(?:[^"]|\\")*)" with "(?P(?:[^"]|\\")*)"$/ - * @deprecated since Moodle 2.7 MDL-43738 - please do not use this step any more. - */ - public function fill_field($field, $value) { - $alternative = 'I set the field "' . $this->escape($field) . '" to "' . $this->escape($value) . '"'; - $this->deprecated_message($alternative, true); - } - - /** - * @When /^I select "(?P(?:[^"]|\\")*)" from "(?P(?:[^"]|\\")*)"$/ - * @deprecated since Moodle 2.7 MDL-43738 - please do not use this step any more. - */ - public function select_option($option, $select) { - $alternative = 'I set the field "' . $this->escape($select) . '" to "' . $this->escape($option) . '"'; - $this->deprecated_message($alternative, true); - } - - /** - * @When /^I select "(?P(?:[^"]|\\")*)" radio button$/ - * @deprecated since Moodle 2.7 MDL-43738 - please do not use this step any more. - */ - public function select_radio($radio) { - $alternative = 'I set the field "' . $this->escape($radio) . '" to "1"'; - $this->deprecated_message($alternative, true); - } - - /** - * @When /^I check "(?P(?:[^"]|\\")*)"$/ - * @deprecated since Moodle 2.7 MDL-43738 - please do not use this step any more. - */ - public function check_option($option) { - $alternative = 'I set the field "' . $this->escape($option) . '" to "1"'; - $this->deprecated_message($alternative, true); - } - - /** - * @When /^I uncheck "(?P(?:[^"]|\\")*)"$/ - * @deprecated since Moodle 2.7 MDL-43738 - please do not use this step any more. - */ - public function uncheck_option($option) { - $alternative = 'I set the field "' . $this->escape($option) . '" to ""'; - $this->deprecated_message($alternative, true); - } - - /** - * @Then /^the "(?P(?:[^"]|\\")*)" field should match "(?P(?:[^"]|\\")*)" value$/ - * @deprecated since Moodle 2.7 MDL-43738 - please do not use this step any more. - */ - public function the_field_should_match_value($locator, $value) { - $alternative = 'the field "' . $this->escape($locator) . '" matches value "' . $this->escape($value) . '"'; - $this->deprecated_message($alternative, true); - } - - /** - * @Then /^the "(?P(?:[^"]|\\")*)" checkbox should be checked$/ - * @deprecated since Moodle 2.7 MDL-43738 - please do not use this step any more. - */ - public function assert_checkbox_checked($checkbox) { - $alternative = 'the field "' . $this->escape($checkbox) . '" matches value "1"'; - $this->deprecated_message($alternative, true); - } - - /** - * @Then /^the "(?P(?:[^"]|\\")*)" checkbox should not be checked$/ - * @deprecated since Moodle 2.7 MDL-43738 - please do not use this step any more. - */ - public function assert_checkbox_not_checked($checkbox) { - $alternative = 'the field "' . $this->escape($checkbox) . '" matches value ""'; - $this->deprecated_message($alternative, true); - } - - /** - * @Given /^I fill the moodle form with:$/ - * @deprecated since Moodle 2.7 MDL-43738 - please do not use this step any more. - */ - public function i_fill_the_moodle_form_with(TableNode $data) { - $alternative = 'I set the following fields to these values:'; - $this->deprecated_message($alternative, true); - } - - /** - * @Then /^"(?P(?:[^"]|\\")*)" "(?P[^"]*)" should exists$/ - * @deprecated since Moodle 2.7 MDL-43236 - please do not use this step any more. - */ - public function should_exists($element, $selectortype) { - $alternative = '"' . $this->escape($element) . '" "' . $this->escape($selectortype) . '" should exist'; - $this->deprecated_message($alternative, true); - } - - /** - * @Then /^"(?P(?:[^"]|\\")*)" "(?P[^"]*)" should not exists$/ - * @deprecated since Moodle 2.7 MDL-43236 - please do not use this step any more. - */ - public function should_not_exists($element, $selectortype) { - $alternative = '"' . $this->escape($element) . '" "' . $this->escape($selectortype) . '" should not exist'; - $this->deprecated_message($alternative, true); - } - - /** - * @Given /^the following "(?P(?:[^"]|\\")*)" exists:$/ - * @deprecated since Moodle 2.7 MDL-43236 - please do not use this step any more. - */ - public function the_following_exists($elementname, TableNode $data) { - $alternative = 'the following "' . $this->escape($elementname) . '" exist:'; - $this->deprecated_message($alternative, true); - } - /** * Sets the specified value to the field. * @@ -291,6 +62,7 @@ class behat_deprecated extends behat_base { * Click on a given link in the moodle-actionmenu that is currently open. * @Given /^I follow "(?P(?:[^"]|\\")*)" in the open menu$/ * @param string $linkstring the text (or id, etc.) of the link to click. + * @deprecated since Moodle 3.2 MDL-55839 - please do not use this step any more. */ public function i_follow_in_the_open_menu($linkstring) { $alternative = 'I choose "' . $this->escape($linkstring) . '" from the open action menu'; diff --git a/lib/upgrade.txt b/lib/upgrade.txt index be273d5cddc..7685742f313 100644 --- a/lib/upgrade.txt +++ b/lib/upgrade.txt @@ -18,6 +18,31 @@ information provided here is intended especially for developers. * The mcore YUI rollup which included various YUI modules such as moodle-core-notification is no longer included on every page. Missing YUI depdencies may be exposed by this change (e.g. missing a requirement on moodle-core-notification when using M.core.dialogue). +* Following behat steps have been removed from core: + - I click on "" "" in the "" table row + - I go to notifications page + - I add "" file from recent files to "" filepicker + - I upload "" file to "" filepicker + - I create "" folder in "" filepicker + - I open "" folder from "" filepicker + - I unzip "" file from "" filepicker + - I zip "" folder from "" filepicker + - I delete "" from "" filepicker + - I send "" message to "" + - I add "" user to "" cohort + - I add "" user to "" group + - I fill in "" with "" + - I select "" from "" + - I select "" radio button + - I check "" + - I uncheck "" + - the "" field should match "" value + - the "" checkbox should be checked + - the "" checkbox should not be checked + - I fill the moodle form with: + - "" "" should exists + - "" "" should not exists + - the following "" exists: === 3.2 ===