From 3c74184ab8fa8be84c969cf2def4844f663b36fc Mon Sep 17 00:00:00 2001 From: Mark Johnson Date: Wed, 3 Dec 2025 09:22:14 +0000 Subject: [PATCH] MDL-86524 quiz: Update restore test with current tag filter format The test for restoring a random question from Moodle 3.9 using tags was still testing for the pre-4.3 filtercondition format. This needed updating to look for the current format. --- public/mod/quiz/tests/quiz_question_restore_test.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/public/mod/quiz/tests/quiz_question_restore_test.php b/public/mod/quiz/tests/quiz_question_restore_test.php index 6f6545cdfb4..8db86f6d825 100644 --- a/public/mod/quiz/tests/quiz_question_restore_test.php +++ b/public/mod/quiz/tests/quiz_question_restore_test.php @@ -614,10 +614,7 @@ final class quiz_question_restore_test extends \advanced_testcase { $setreference = $DB->get_record('question_set_references', ['itemid' => $slot->id, 'component' => 'mod_quiz', 'questionarea' => 'slot']); $filterconditions = json_decode($setreference->filtercondition); - $tags = []; - foreach ($filterconditions->filter->qtagids->values as $tagid) { - $tags[] = \core_tag_tag::get($tagid, 'id, name')->name; - } + $tags = array_map(fn($tag) => $tag->name, \core_tag_tag::get_bulk($filterconditions->filter->qtagids->values)); $this->assertEquals([], array_diff($randomtags[$slot->slot], $tags)); } }