From 3be59be3496ad02b38afa45c6c0ae06d938efec9 Mon Sep 17 00:00:00 2001 From: Marina Glancy Date: Thu, 19 Nov 2015 11:06:48 +0800 Subject: [PATCH] MDL-52203 qtype_multianswer: avoid fatal error during upgrade --- question/type/multianswer/db/upgrade.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/question/type/multianswer/db/upgrade.php b/question/type/multianswer/db/upgrade.php index c6935d3a57b..e5c3839f309 100644 --- a/question/type/multianswer/db/upgrade.php +++ b/question/type/multianswer/db/upgrade.php @@ -67,10 +67,10 @@ function xmldb_qtype_multianswer_upgrade($oldversion) { FROM {question} q JOIN {question_multianswer} qma ON q.id = qma.question"); foreach ($rs as $q) { - if (!empty($q->sequence)) { + $sequence = preg_split('/,/', $q->sequence, -1, PREG_SPLIT_NO_EMPTY); + if ($sequence) { // Get relevant data indexed by positionkey from the multianswers table. - $wrappedquestions = $DB->get_records_list('question', 'id', - explode(',', $q->sequence), 'id ASC'); + $wrappedquestions = $DB->get_records_list('question', 'id', $sequence, 'id ASC'); foreach ($wrappedquestions as $wrapped) { if ($wrapped->qtype == 'multichoice') { $options = $DB->get_record('qtype_multichoice_options', array('questionid' => $wrapped->id), '*');