From e2b6ee0e3bb145a89978c70951f08f112f7892d5 Mon Sep 17 00:00:00 2001
From: Jake Dallimore <jake@moodle.com>
Date: Fri, 2 May 2025 10:01:11 +0800
Subject: [PATCH] MDL-85341 core: remove unnecessary sesskey from module
 controlmenu items

This impacts the following controls:
- edit (sesskey removed from link)
All other controls should remain unchanged in terms of their use of
sesskey, supporting action handling for non-js course home (see non-js
behat tests move_activities.feature).
---
 course/lib.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/course/lib.php b/course/lib.php
index e8fd2d4c2df..a03d5bf0ee6 100644
--- a/course/lib.php
+++ b/course/lib.php
@@ -1369,7 +1369,7 @@ function course_get_cm_edit_actions(cm_info $mod, $indent = -1, $sr = null) {
         $str->groupmode = get_string('groupmode', 'group');
     }
 
-    $baseurl = new moodle_url('/course/mod.php', array('sesskey' => sesskey()));
+    $baseurl = new moodle_url('/course/mod.php');
 
     if ($sr !== null) {
         $baseurl->param('sr', $sr);
@@ -1424,7 +1424,7 @@ function course_get_cm_edit_actions(cm_info $mod, $indent = -1, $sr = null) {
             $enabledclass = '';
         }
         $actions['moveright'] = new action_menu_link_secondary(
-            new moodle_url($baseurl, ['id' => $mod->id, 'indent' => '1']),
+            new moodle_url($baseurl, ['id' => $mod->id, 'indent' => '1', 'sesskey' => sesskey()]),
             new pix_icon($rightarrow, '', 'moodle', ['class' => 'iconsmall']),
             $str->moveright,
             [
@@ -1472,7 +1472,7 @@ function course_get_cm_edit_actions(cm_info $mod, $indent = -1, $sr = null) {
             plugin_supports('mod', $mod->modname, FEATURE_BACKUP_MOODLE2) &&
             course_allowed_module($mod->get_course(), $mod->modname)) {
         $actions['duplicate'] = new action_menu_link_secondary(
-            new moodle_url($baseurl, ['duplicate' => $mod->id]),
+            new moodle_url($baseurl, ['duplicate' => $mod->id, 'sesskey' => sesskey()]),
             new pix_icon('t/copy', '', 'moodle', array('class' => 'iconsmall')),
             $str->duplicate,
             [