From 3a1237997a327f8d39328ea8efb8701e8b24b1e7 Mon Sep 17 00:00:00 2001
From: Jetha Chan <jetha@moodle.org>
Date: Tue, 18 Mar 2014 14:19:36 +0800
Subject: [PATCH] MDL-44148 portfolio: set_user_config usage fix

Amended user/portfolio.php's use of portfolio_plugin_base::set_user_config to be consistent with the API.
---
 user/portfolio.php | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/user/portfolio.php b/user/portfolio.php
index 6d09c75e600..35955114423 100644
--- a/user/portfolio.php
+++ b/user/portfolio.php
@@ -77,15 +77,11 @@ if (!empty($config)) {
         if (!confirm_sesskey()) {
             print_error('confirmsesskeybad', '', $baseurl);
         }
-        //this branch is where you process validated data.
-        $success = $instance->set_user_config($fromform, $USER->id);
-            //$success = $success && $instance->save();
-        if ($success) {
-            core_plugin_manager::reset_caches();
-            redirect($baseurl, get_string('instancesaved', 'portfolio'), 3);
-        } else {
-            print_error('instancenotsaved', 'portfolio', $baseurl);
-        }
+        // This branch is where you process validated data.
+        $instance->set_user_config($fromform, $USER->id);
+        core_plugin_manager::reset_caches();
+        redirect($baseurl, get_string('instancesaved', 'portfolio'), 3);
+
         exit;
     } else {
         echo $OUTPUT->heading(get_string('configplugin', 'portfolio'));