diff --git a/mod/choice/report.php b/mod/choice/report.php index 328c160e042..ec8cad8c657 100644 --- a/mod/choice/report.php +++ b/mod/choice/report.php @@ -47,7 +47,7 @@ } if (!$users) { - print_heading(get_string("nousersyet")); + print_heading(get_string("nousersyet")); } if ($allresponses = get_records("choice_answers", "choiceid", $choice->id)) { diff --git a/mod/choice/view.php b/mod/choice/view.php index 2017674eb80..4e7b6457a47 100644 --- a/mod/choice/view.php +++ b/mod/choice/view.php @@ -3,7 +3,7 @@ require_once("../../config.php"); require_once("lib.php"); - $id = required_param('id',PARAM_INT); // Course Module ID + require_variable($id); // Course Module ID if (! $cm = get_record("course_modules", "id", $id)) { error("Course Module ID was incorrect"); diff --git a/mod/quiz/export.php b/mod/quiz/export.php index e611ad2cb21..8799787b2bc 100644 --- a/mod/quiz/export.php +++ b/mod/quiz/export.php @@ -93,10 +93,6 @@ /// Print upload form - if (!$categories = quiz_get_category_menu($course->id, false)) { - error("No categories!"); - } - // get valid formats to generate dropdown list $fileformatnames = get_import_export_formats( "export" ); diff --git a/mod/quiz/import.php b/mod/quiz/import.php index 24e710b3102..7fb8a5991fe 100644 --- a/mod/quiz/import.php +++ b/mod/quiz/import.php @@ -84,10 +84,6 @@ /// Print upload form - if (!$categories = quiz_get_category_menu($course->id, false)) { - error("No categories!"); - } - // get list of available import formats $fileformatnames = get_import_export_formats( 'import' ); diff --git a/mod/resource/fetch.php b/mod/resource/fetch.php index 3e67bd08e4a..4cb9f82b20c 100644 --- a/mod/resource/fetch.php +++ b/mod/resource/fetch.php @@ -6,8 +6,8 @@ require_once("../../config.php"); require_once("lib.php"); - $id = required_param('id',0,PARAM_INT); // Course Module ID - $url = required_param('url'); // url to fetch + $id = required_param('id', PARAM_INT); // Course Module ID + $url = required_param('url', PARAM_URL); // url to fetch if (! $cm = get_record("course_modules", "id", $id)) { error("Course Module ID was incorrect");