L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-69687 DB: Add API for deleting data based on subquery

Browse Source 
The new API works on normal databases (by deleting data based on the
subquery) and also on MySQL (by deleting the data using a weird join
on the subquery).
This commit is contained in:
sam marshall
2020-10-16 18:22:51 +01:00
parent 36f0c3d531
commit 39eb58c754
4 changed files with 65 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/dml/tests/dml_test.php
+23
View File
@@ -3491,6 +3491,29 @@ EOD;
$this->assertEquals(1, $DB->count_records($tablename));
}
public function test_delete_records_subquery() {
$DB = $this->tdb;
$dbman = $DB->get_manager();
$table = $this->get_test_table();
$tablename = $table->getName();
$table->add_field('id', XMLDB_TYPE_INTEGER, '10', null, XMLDB_NOTNULL, XMLDB_SEQUENCE, null);
$table->add_field('course', XMLDB_TYPE_INTEGER, '10', null, XMLDB_NOTNULL, null, '0');
$table->add_key('primary', XMLDB_KEY_PRIMARY, array('id'));
$dbman->create_table($table);
$DB->insert_record($tablename, array('course' => 3));
$DB->insert_record($tablename, array('course' => 2));
$DB->insert_record($tablename, array('course' => 2));
// This is not a useful scenario for using a subquery, but it will be sufficient for testing.
// Use the 'frog' alias just to make it clearer when we are testing the alias parameter.
$DB->delete_records_subquery($tablename, 'id', 'frog',
'SELECT id AS frog FROM {' . $tablename . '} WHERE course = ?', [2]);
$this->assertEquals(1, $DB->count_records($tablename));
}
public function test_delete_records_list() {
$DB = $this->tdb;
$dbman = $DB->get_manager();