From 381f45d005a97b5de25e8317689fab5d9d438f08 Mon Sep 17 00:00:00 2001 From: Michael Hawkins Date: Fri, 26 Jun 2020 18:22:26 +0800 Subject: [PATCH] MDL-69129 report: Limit config changes report sort direction values --- report/configlog/index.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/report/configlog/index.php b/report/configlog/index.php index 730448f376c..614c644f446 100644 --- a/report/configlog/index.php +++ b/report/configlog/index.php @@ -54,6 +54,9 @@ if (!isset($columns[$sort])) { $sort = 'lastname'; } +// Sort direction can only be ASC or DESC. Fall back to default (DESC) for invalid values. +$dir = $dir != 'ASC' ? 'DESC' : 'ASC'; + foreach ($columns as $column=>$strcolumn) { if ($sort != $column) { $columnicon = '';