From 37b6eea44f4e0130a9530cf83234da47d8a98aa2 Mon Sep 17 00:00:00 2001 From: Laurent David Date: Mon, 8 Jul 2024 10:44:39 +0200 Subject: [PATCH] MDL-81265 mod_workshop: Fix accessibility issues * Page title should be h2 * Contrasts in the table headers (for submission, assessment and grading) should be 4:1 at least --- mod/workshop/renderer.php | 2 +- mod/workshop/styles.css | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/mod/workshop/renderer.php b/mod/workshop/renderer.php index 3109026b086..0c33d404cf3 100644 --- a/mod/workshop/renderer.php +++ b/mod/workshop/renderer.php @@ -1261,7 +1261,7 @@ class mod_workshop_renderer extends plugin_renderer_base { $output = ''; $output .= $this->render_action_buttons($workshop, $userplan); - $output .= $this->heading(format_string($currentphasetitle), 3, null, 'mod_workshop-userplanheading'); + $output .= $this->heading(format_string($currentphasetitle), 2, null, 'mod_workshop-userplanheading'); $output .= $this->render($userplan); $output .= $this->view_submissions_report($workshop, $userplan, $page, $sortby, $sorthow); diff --git a/mod/workshop/styles.css b/mod/workshop/styles.css index 43164e63550..779aa7a0529 100644 --- a/mod/workshop/styles.css +++ b/mod/workshop/styles.css @@ -243,15 +243,16 @@ .path-mod-workshop .userplan dt { vertical-align: bottom; white-space: normal; - color: #999; - border-bottom: 1px solid #ddd; + color: #495057; + background-color: #f5f5f5; + border-bottom: 1px solid #ced4da; padding: 3px; } .path-mod-workshop .userplan dt.active { vertical-align: top; - color: black; - border: 1px solid #ddd; + color: #212529; + border: 1px solid #ced4da; border-bottom: 0; border-top: 0; background: #e7f1c3; @@ -322,7 +323,7 @@ .path-mod-workshop .userplan dd { vertical-align: top; - border-right: 1px solid #ddd; + border-right: 1px solid #ced4da; background-color: #f5f5f5; margin: 0; min-height: 180px; @@ -335,7 +336,7 @@ .path-mod-workshop .userplan dd a:hover, .path-mod-workshop .userplan dd a:visited, .path-mod-workshop .userplan dd a:active { - color: #999; + color: #495057; } .path-mod-workshop .userplan dd.active, @@ -344,7 +345,7 @@ .path-mod-workshop .userplan dd.active a:hover, .path-mod-workshop .userplan dd.active a:visited, .path-mod-workshop .userplan dd.active a:active { - color: black; + color: #212529; } .path-mod-workshop .userplan dd.lastcol {