diff --git a/question/classes/bank/view.php b/question/classes/bank/view.php index 98ba1f7ebb0..04e076d5385 100644 --- a/question/classes/bank/view.php +++ b/question/classes/bank/view.php @@ -715,8 +715,13 @@ class view { echo $OUTPUT->render($pagingbar); if ($totalnumber > DEFAULT_QUESTIONS_PER_PAGE) { if ($perpage == DEFAULT_QUESTIONS_PER_PAGE) { - $url = new \moodle_url('edit.php', array_merge($pageurl->params(), array('qperpage' => 1000))); - $showall = ''.get_string('showall', 'moodle', $totalnumber).''; + $url = new \moodle_url('edit.php', array_merge($pageurl->params(), + array('qperpage' => MAXIMUM_QUESTIONS_PER_PAGE))); + if ($totalnumber > MAXIMUM_QUESTIONS_PER_PAGE) { + $showall = ''.get_string('showperpage', 'moodle', MAXIMUM_QUESTIONS_PER_PAGE).''; + } else { + $showall = ''.get_string('showall', 'moodle', $totalnumber).''; + } } else { $url = new \moodle_url('edit.php', array_merge($pageurl->params(), array('qperpage' => DEFAULT_QUESTIONS_PER_PAGE))); diff --git a/question/editlib.php b/question/editlib.php index ff7800dab84..922bc672859 100644 --- a/question/editlib.php +++ b/question/editlib.php @@ -31,6 +31,7 @@ defined('MOODLE_INTERNAL') || die(); require_once($CFG->libdir . '/questionlib.php'); define('DEFAULT_QUESTIONS_PER_PAGE', 20); +define('MAXIMUM_QUESTIONS_PER_PAGE', 1000); function get_module_from_cmid($cmid) { global $CFG, $DB;