From 369cb15125f3335fc8b190d4355eca7d21df4a25 Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Thu, 27 Nov 2025 17:30:23 +0800 Subject: [PATCH] MDL-85858 mod_scorm: Use semantic heading for the Preview mode --- public/mod/scorm/lang/en/scorm.php | 1 + public/mod/scorm/player.php | 3 ++- public/mod/scorm/styles.css | 5 ----- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/public/mod/scorm/lang/en/scorm.php b/public/mod/scorm/lang/en/scorm.php index c02140c416a..1e8dc9bc93b 100644 --- a/public/mod/scorm/lang/en/scorm.php +++ b/public/mod/scorm/lang/en/scorm.php @@ -73,6 +73,7 @@ $string['badarchive'] = 'You must provide a valid zip file'; $string['browse'] = 'Preview'; $string['browsed'] = 'Browsed'; $string['browsemode'] = 'Preview mode'; +$string['browsemodewithname'] = 'Preview mode: {$a}'; $string['browserepository'] = 'Browse repository'; $string['cachedef_elements'] = 'Element cache'; $string['calculatedweight'] = 'Calculated weight'; diff --git a/public/mod/scorm/player.php b/public/mod/scorm/player.php index c5ae795d00c..28b5fe66056 100644 --- a/public/mod/scorm/player.php +++ b/public/mod/scorm/player.php @@ -228,7 +228,8 @@ echo html_writer::div(html_writer::tag('script', '', array('id' => 'external-sco if ($scorm->hidetoc == SCORM_TOC_POPUP or $mode == 'browse' or $mode == 'review') { echo html_writer::start_div('mb-3', array('id' => 'scormtop')); if ($mode == 'browse' || $mode == 'review') { - echo html_writer::div(get_string("{$mode}mode", 'scorm'), 'scorm-left h3', ['id' => 'scormmode']); + $headinglevel = $PAGE->activityheader->get_heading_level(); + echo $OUTPUT->heading(get_string("{$mode}mode", 'scorm'), $headinglevel, 'scorm-left', 'scormmode'); } if ($scorm->hidetoc == SCORM_TOC_POPUP) { echo html_writer::div($result->tocmenu, 'scorm-right', array('id' => 'scormnav')); diff --git a/public/mod/scorm/styles.css b/public/mod/scorm/styles.css index 7246048ff75..0a6950f7c6d 100644 --- a/public/mod/scorm/styles.css +++ b/public/mod/scorm/styles.css @@ -164,11 +164,6 @@ padding: 0; } -#page-mod-scorm-player #scormmode { - float: left; - border: 0; -} - #page-mod-scorm-player.pagelayout-popup #page-content .region-content { padding: 0; }