L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-49329 admin: If unable to install a plugin, display the reason

Browse Source
This commit is contained in:
David Mudrák
2015-10-08 23:32:04 +02:00
parent f65d337089
commit 36977a6d08
5 changed files with 44 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/renderer.php
+25 -1
View File
@@ -1233,13 +1233,18 @@ class core_admin_renderer extends plugin_renderer_base {
$info .= html_writer::div(html_writer::link($plugin->version->downloadurl, get_string('download')), 'misdepdownload');
if ($pluginman->is_remote_plugin_installable($plugin->component, $plugin->version->version)) {
if ($pluginman->is_remote_plugin_installable($plugin->component, $plugin->version->version, $reason)) {
$info .= $this->output->single_button(
new moodle_url($this->page->url, array('installdep' => $plugin->component)),
get_string('dependencyinstall', 'core_plugin'),
'post',
array('class' => 'singlebutton dependencyinstall')
);
} else {
$reasonhelp = $this->info_remote_plugin_not_installable($reason);
if ($reasonhelp) {
$info .= html_writer::div($reasonhelp, 'reasonhelp dependencyinstall');
}
}
$info .= $this->output->container_end(); // .actions
@@ -1256,6 +1261,25 @@ class core_admin_renderer extends plugin_renderer_base {
return html_writer::table($table);
}
/**
* Explain why {@link core_plugin_manager::is_remote_plugin_installable()} returned false.
*
* @param string $reason the reason code as returned by the plugin manager
* @return string
*/
protected function info_remote_plugin_not_installable($reason) {
if ($reason === 'notwritableplugintype' or $reason === 'notwritableplugin') {
return $this->output->help_icon('notwritable', 'core_plugin', get_string('notwritable', 'core_plugin'));
}
if ($reason === 'remoteunavailable') {
return $this->output->help_icon('notdownloadable', 'core_plugin', get_string('notdownloadable', 'core_plugin'));
}
return false;
}
/**
* Formats the information that needs to go in the 'Requires' column.
* @param \core\plugininfo\base $plugin the plugin we are rendering the row for.