L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-75952 general: Since php81, refection->setAccessible() is no-op

Browse Source 
Refereces:
- https://wiki.php.net/rfc/make-reflection-setaccessible-no-op
- https://www.php.net/manual/en/reflectionproperty.setaccessible.php
- https://www.php.net/manual/en/reflectionmethod.setaccessible.php

As of PHP 8.1.0, calling this method has no effect; all methods are
invokable by default. So, let's remove all uses from core, they are
no-op.
This commit is contained in:
Eloy Lafuente (stronk7)
2024-03-10 21:15:00 +01:00
parent 38a3310c92
commit 361dfe8145
134 changed files with 7 additions and 383 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/phpunit/tests/phpunit_dataset_test.php
-18
View File
@@ -54,11 +54,8 @@ class phpunit_dataset_test extends advanced_testcase {
// We need public properties to check the basis.
$dsref = new \ReflectionClass($ds);
$dstables = $dsref->getProperty('tables');
$dstables->setAccessible(true);
$dscolumns = $dsref->getProperty('columns');
$dscolumns->setAccessible(true);
$dsrows = $dsref->getProperty('rows');
$dsrows->setAccessible(true);
// Expectations.
$exptables = ['user', 'user2'];
@@ -158,11 +155,8 @@ class phpunit_dataset_test extends advanced_testcase {
// We need public properties to check the basis.
$dsref = new \ReflectionClass($ds);
$dstables = $dsref->getProperty('tables');
$dstables->setAccessible(true);
$dscolumns = $dsref->getProperty('columns');
$dscolumns->setAccessible(true);
$dsrows = $dsref->getProperty('rows');
$dsrows->setAccessible(true);
// We are expecting an exception.
if (!empty($exception)) {
@@ -251,11 +245,8 @@ class phpunit_dataset_test extends advanced_testcase {
// We need public properties to check the basis.
$dsref = new \ReflectionClass($ds);
$dstables = $dsref->getProperty('tables');
$dstables->setAccessible(true);
$dscolumns = $dsref->getProperty('columns');
$dscolumns->setAccessible(true);
$dsrows = $dsref->getProperty('rows');
$dsrows->setAccessible(true);
// We are expecting an exception.
if (!empty($exception)) {
@@ -397,11 +388,8 @@ class phpunit_dataset_test extends advanced_testcase {
// We need public properties to check the basis.
$dsref = new \ReflectionClass($ds);
$dstables = $dsref->getProperty('tables');
$dstables->setAccessible(true);
$dscolumns = $dsref->getProperty('columns');
$dscolumns->setAccessible(true);
$dsrows = $dsref->getProperty('rows');
$dsrows->setAccessible(true);
// We are expecting an exception.
if (!empty($exception)) {
@@ -491,11 +479,8 @@ class phpunit_dataset_test extends advanced_testcase {
// We need public properties to check the basis.
$dsref = new \ReflectionClass($ds);
$dstables = $dsref->getProperty('tables');
$dstables->setAccessible(true);
$dscolumns = $dsref->getProperty('columns');
$dscolumns->setAccessible(true);
$dsrows = $dsref->getProperty('rows');
$dsrows->setAccessible(true);
// We are expecting an exception.
if (!empty($exception)) {
@@ -662,11 +647,8 @@ class phpunit_dataset_test extends advanced_testcase {
// We need public properties to check the basis.
$dsref = new \ReflectionClass($ds);
$dstables = $dsref->getProperty('tables');
$dstables->setAccessible(true);
$dscolumns = $dsref->getProperty('columns');
$dscolumns->setAccessible(true);
$dsrows = $dsref->getProperty('rows');
$dsrows->setAccessible(true);
// We are expecting an exception.
if (!empty($exception)) {