From 331f47a4f3ec8a89c4dfa7c19b217990947f6af6 Mon Sep 17 00:00:00 2001
From: Jake Dallimore <jake@moodle.com>
Date: Thu, 22 Jun 2023 10:54:46 +0800
Subject: [PATCH] MDL-78544 forms: fix string to number comparison bug in
 duration element

Prior to PHP 8, 0 == "", but now no more. We should use empty instead.
See: https://www.php.net/manual/en/migration80.incompatible.php
---
 lib/form/duration.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/form/duration.php b/lib/form/duration.php
index 41b12fcc349..aeb152a1c0f 100644
--- a/lib/form/duration.php
+++ b/lib/form/duration.php
@@ -157,7 +157,7 @@ class MoodleQuickForm_duration extends MoodleQuickForm_group {
      * @return array associative array ($number => $unit)
      */
     public function seconds_to_unit($seconds) {
-        if ($seconds == 0) {
+        if (empty($seconds)) {
             return [0, $this->_options['defaultunit']];
         }
         foreach ($this->get_units_used() as $unit => $notused) {