From 33135d96ca80600c9f07cb55ab36e4ecbcdff089 Mon Sep 17 00:00:00 2001
From: Sara Arjona <sara@moodle.com>
Date: Fri, 20 Dec 2024 16:22:05 +0100
Subject: [PATCH] MDL-84049 badges: Remove default apiversion value

Remove the default value for the apiversion field in the
badge_external_backpack table.
---
 lib/db/install.xml |  2 +-
 lib/db/upgrade.php | 10 ++++++++++
 version.php        |  2 +-
 3 files changed, 12 insertions(+), 2 deletions(-)
 mode change 100644 => 100755 lib/db/install.xml

diff --git a/lib/db/install.xml b/lib/db/install.xml
old mode 100644
new mode 100755
index d7860f0c82d..6cef0858a37
--- a/lib/db/install.xml
+++ b/lib/db/install.xml
@@ -3404,7 +3404,7 @@
         <FIELD NAME="id" TYPE="int" LENGTH="10" NOTNULL="true" SEQUENCE="true"/>
         <FIELD NAME="backpackapiurl" TYPE="char" LENGTH="255" NOTNULL="true" SEQUENCE="false"/>
         <FIELD NAME="backpackweburl" TYPE="char" LENGTH="255" NOTNULL="true" SEQUENCE="false"/>
-        <FIELD NAME="apiversion" TYPE="char" LENGTH="12" NOTNULL="true" DEFAULT="1.0" SEQUENCE="false"/>
+        <FIELD NAME="apiversion" TYPE="char" LENGTH="12" NOTNULL="true" SEQUENCE="false"/>
         <FIELD NAME="sortorder" TYPE="int" LENGTH="10" NOTNULL="true" DEFAULT="0" SEQUENCE="false"/>
         <FIELD NAME="oauth2_issuerid" TYPE="int" LENGTH="10" NOTNULL="false" SEQUENCE="false" COMMENT="OAuth 2 Issuer"/>
       </FIELDS>
diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php
index 5daf03673aa..1cdcc28b500 100644
--- a/lib/db/upgrade.php
+++ b/lib/db/upgrade.php
@@ -1382,5 +1382,15 @@ function xmldb_main_upgrade($oldversion) {
         upgrade_main_savepoint(true, 2025011700.02);
     }
 
+    if ($oldversion < 2025012400.01) {
+        // Remove the default value for the apiversion field.
+        $table = new xmldb_table('badge_external_backpack');
+        $apiversionfield = new xmldb_field('apiversion', XMLDB_TYPE_CHAR, '12', null, XMLDB_NOTNULL, null, null);
+        $dbman->change_field_default($table, $apiversionfield);
+
+        // Main savepoint reached.
+        upgrade_main_savepoint(true, 2025012400.01);
+    }
+
     return true;
 }
diff --git a/version.php b/version.php
index 8edfdf4fd01..41a2b24ff31 100644
--- a/version.php
+++ b/version.php
@@ -29,7 +29,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$version  = 2025012400.00;              // YYYYMMDD      = weekly release date of this DEV branch.
+$version  = 2025012400.01;              // YYYYMMDD      = weekly release date of this DEV branch.
                                         //         RR    = release increments - 00 in DEV branches.
                                         //           .XX = incremental changes.
 $release  = '5.0dev (Build: 20250124)';    // Human-friendly version name