From 32b1faf8b727737dcdf7edbec9446dd1086d249c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Mudr=C3=A1k?= Date: Sun, 25 Nov 2018 06:55:23 +0100 Subject: [PATCH] MDL-64205 users: Do not delete the actual records of unconfirmed users There is an automatic data privacy request created to get rid of all the personal data upon the user deletion. With the actual user record absent, the data privacy requests page throws an error. Let's do here same as we do in `delete_incomplete_users_task` and let us not delete the actual user record. --- lib/classes/task/delete_unconfirmed_users_task.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/classes/task/delete_unconfirmed_users_task.php b/lib/classes/task/delete_unconfirmed_users_task.php index b9aa9a32a86..40dfe8ef1ef 100644 --- a/lib/classes/task/delete_unconfirmed_users_task.php +++ b/lib/classes/task/delete_unconfirmed_users_task.php @@ -54,9 +54,8 @@ class delete_unconfirmed_users_task extends scheduled_task { WHERE confirmed = 0 AND timecreated > 0 AND timecreated < ? AND deleted = 0", array($cuttime)); foreach ($rs as $user) { - delete_user($user); // We MUST delete user properly first. - $DB->delete_records('user', array('id' => $user->id)); // This is a bloody hack, but it might work. - mtrace(" Deleted unconfirmed user for ".fullname($user, true)." ($user->id)"); + delete_user($user); + mtrace(" Deleted unconfirmed user ".fullname($user, true)." ($user->id)"); } $rs->close(); }