From 27758f45f17211ccfcb92bc37191051c1c42a029 Mon Sep 17 00:00:00 2001
From: Brendan Heywood <brendan@catalyst-au.net>
Date: Sat, 7 Nov 2020 17:27:46 +1100
Subject: [PATCH] MDL-51111 cache: Don't lock and write the config file if
 unchanged

---
 cache/locallib.php | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/cache/locallib.php b/cache/locallib.php
index db20b05fb2f..572e2f8e55c 100644
--- a/cache/locallib.php
+++ b/cache/locallib.php
@@ -68,6 +68,7 @@ class cache_config_writer extends cache_config {
      */
     protected function config_save() {
         global $CFG;
+        static $confighash = '';
         $cachefile = static::get_config_file_path();
         $directory = dirname($cachefile);
         if ($directory !== $CFG->dataroot && !file_exists($directory)) {
@@ -86,6 +87,15 @@ class cache_config_writer extends cache_config {
         // Prepare the file content.
         $content = "<?php defined('MOODLE_INTERNAL') || die();\n \$configuration = ".var_export($configuration, true).";";
 
+        // Do both file content and hash based detection because this might be called
+        // many times within a single request.
+        $hash = sha1($content);
+        if (($hash === $confighash) || (file_exists($cachefile) && $content === file_get_contents($cachefile))) {
+            // Config is unchanged so don't bother locking and writing.
+            $confighash = $hash;
+            return;
+        }
+
         // We need to create a temporary cache lock instance for use here. Remember we are generating the config file
         // it doesn't exist and thus we can't use the normal API for this (it'll just try to use config).
         $lockconf = reset($this->configlocks);