From 30e2ad8b853ea58052a5d6cdb0db2fde398b9a94 Mon Sep 17 00:00:00 2001 From: Jerome Mouneyrac Date: Wed, 23 Jan 2013 14:15:00 +0800 Subject: [PATCH] MDL-37476 course_create unit test fails if course completion is enabled --- course/tests/externallib_test.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/course/tests/externallib_test.php b/course/tests/externallib_test.php index bdfc63605d5..1eb755ed70f 100644 --- a/course/tests/externallib_test.php +++ b/course/tests/externallib_test.php @@ -322,6 +322,9 @@ class core_course_external_testcase extends externallib_advanced_testcase { $this->resetAfterTest(true); + // Enable course completion. + set_config('enablecompletion', 1); + // Set the required capabilities by the external function $contextid = context_system::instance()->id; $roleid = $this->assignUserCapability('moodle/course:create', $contextid); @@ -396,13 +399,8 @@ class core_course_external_testcase extends externallib_advanced_testcase { $this->assertEquals($dbcourse->theme, $course2['forcetheme']); } - if (completion_info::is_enabled_for_site()) { - $this->assertEquals($dbcourse->enablecompletion, $course2['enabledcompletion']); - $this->assertEquals($dbcourse->completionstartonenrol, $course2['completionstartonenrol']); - } else { - $this->assertEquals($dbcourse->enablecompletion, 0); - $this->assertEquals($dbcourse->completionstartonenrol, 0); - } + $this->assertEquals($dbcourse->enablecompletion, $course2['enablecompletion']); + $this->assertEquals($dbcourse->completionstartonenrol, $course2['completionstartonenrol']); } else if ($createdcourse['shortname'] == $course1['shortname']) { $courseconfig = get_config('moodlecourse');