From 05bbda7b403ddba521e532e368dd7de0dbb99568 Mon Sep 17 00:00:00 2001 From: Damyon Wiese Date: Tue, 28 Jul 2015 10:19:59 +0800 Subject: [PATCH] MDL-46078 Assign: Completion is not using assignment API. Should not be directly querying the DB to get the submission, use the API! --- mod/assign/lib.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mod/assign/lib.php b/mod/assign/lib.php index 56887bfc163..9a4e2667331 100644 --- a/mod/assign/lib.php +++ b/mod/assign/lib.php @@ -1228,8 +1228,7 @@ function assign_get_completion_state($course, $cm, $userid, $type) { // If completion option is enabled, evaluate it and return true/false. if ($assign->get_instance()->completionsubmit) { - $dbparams = array('assignment'=>$assign->get_instance()->id, 'userid'=>$userid); - $submission = $DB->get_record('assign_submission', $dbparams, '*', IGNORE_MISSING); + $submission = $assign->get_user_submission($userid, false); return $submission && $submission->status == ASSIGN_SUBMISSION_STATUS_SUBMITTED; } else { // Completion option is not enabled so just return $type.