From 2bc980a970f70be9cf10dd784358ead85314454a Mon Sep 17 00:00:00 2001 From: Andrew Nicols Date: Mon, 24 Feb 2014 11:48:27 +0800 Subject: [PATCH] MDL-44061 Ajax: Log whitespace issues to the server error log --- lib/ajax/ajaxlib.php | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/ajax/ajaxlib.php b/lib/ajax/ajaxlib.php index c9f21f85344..7b7b283ee71 100644 --- a/lib/ajax/ajaxlib.php +++ b/lib/ajax/ajaxlib.php @@ -96,11 +96,15 @@ function ajax_check_captured_output() { $output = ob_get_contents(); ob_end_clean(); - if ($CFG->debugdeveloper && !empty($output)) { - // Only throw an error if the site is in debugdeveloper. - throw new coding_exception('Unexpected output whilst processing AJAX request. ' . + if (!empty($output)) { + $message = 'Unexpected output whilst processing AJAX request. ' . 'This could be caused by trailing whitespace. Output received: ' . - var_export($output, true)); + var_export($output, true); + if ($CFG->debugdeveloper && !empty($output)) { + // Only throw an error if the site is in debugdeveloper. + throw new coding_exception($message); + } + error_log('Potential coding error: ' . $message); } return $output; }