From 2f4ec8a0a7cddbbd8cd23eae4ac99a81c3df31e0 Mon Sep 17 00:00:00 2001
From: tjhunt <tjhunt>
Date: Tue, 31 Mar 2009 03:24:15 +0000
Subject: [PATCH] MDL-15484 Avoid JavaScript errors after a popup has been
 blocked.

Also clean up coding style of some nearby functions.
---
 lib/javascript.php | 39 ++++++++++++++++++++-------------------
 1 file changed, 20 insertions(+), 19 deletions(-)

diff --git a/lib/javascript.php b/lib/javascript.php
index cff899ea978..83f62928ff2 100644
--- a/lib/javascript.php
+++ b/lib/javascript.php
@@ -33,31 +33,32 @@ setTimeout('fix_column_widths()', 20);
 </script>
 <script type="text/javascript">
 //<![CDATA[
-function openpopup(url,name,options,fullscreen) {
-  fullurl = "<?php echo $CFG->httpswwwroot ?>" + url;
-  windowobj = window.open(fullurl,name,options);
-  if (fullscreen) {
-     windowobj.moveTo(0,0);
-     windowobj.resizeTo(screen.availWidth,screen.availHeight);
-  }
-  windowobj.focus();
-  return false;
+function openpopup(url, name, options, fullscreen) {
+    var fullurl = "<?php echo $CFG->httpswwwroot ?>" + url;
+    var windowobj = window.open(fullurl, name, options);
+    if (!windowobj) {
+        return true;
+    }
+    if (fullscreen) {
+        windowobj.moveTo(0, 0);
+        windowobj.resizeTo(screen.availWidth, screen.availHeight);
+    }
+    windowobj.focus();
+    return false;
 }
 
 function uncheckall() {
-  void(d=document);
-  void(el=d.getElementsByTagName('INPUT'));
-  for(i=0;i<el.length;i++) {
-    void(el[i].checked=0);
-  }
+    var inputs = document.getElementsByTagName('input');
+    for(var i = 0; i < inputs.length; i++) {
+        inputs[i].checked = false;
+    }
 }
 
 function checkall() {
-  void(d=document);
-  void(el=d.getElementsByTagName('INPUT'));
-  for(i=0;i<el.length;i++) {
-    void(el[i].checked=1);
-  }
+    var inputs = document.getElementsByTagName('input');
+    for(var i = 0; i < inputs.length; i++) {
+        inputs[i].checked = true;
+    }
 }
 
 function inserttext(text) {