diff --git a/message/index.php b/message/index.php index f057584f26c..43e52934818 100644 --- a/message/index.php +++ b/message/index.php @@ -115,6 +115,10 @@ unset($user2id); $systemcontext = context_system::instance(); +if (!empty($user2) && $user1->id == $user2->id) { + print_error('invaliduserid'); +} + // Is the user involved in the conversation? // Do they have the ability to read other user's conversations? if (!message_current_user_is_involved($user1, $user2) && !has_capability('moodle/site:readallmessages', $systemcontext)) { diff --git a/message/lib.php b/message/lib.php index 3b1cbca77b1..bd642ce697d 100644 --- a/message/lib.php +++ b/message/lib.php @@ -1464,7 +1464,7 @@ function message_history_link($userid1, $userid2, $return=false, $keywords='', $ * @param int|array $courseids Course ID or array of course IDs. * @param string $searchtext the text to search for. * @param string $sort the column name to order by. - * @param string $exceptions comma separated list of user IDs to exclude + * @param string|array $exceptions comma separated list or array of user IDs to exclude. * @return array An array of {@link $USER} records. */ function message_search_users($courseids, $searchtext, $sort='', $exceptions='') { @@ -1481,12 +1481,7 @@ function message_search_users($courseids, $searchtext, $sort='', $exceptions='') } $fullname = $DB->sql_fullname(); - - if (!empty($exceptions)) { - $except = ' AND u.id NOT IN ('. $exceptions .') '; - } else { - $except = ''; - } + $ufields = user_picture::fields('u'); if (!empty($sort)) { $order = ' ORDER BY '. $sort; @@ -1494,22 +1489,38 @@ function message_search_users($courseids, $searchtext, $sort='', $exceptions='') $order = ''; } - $ufields = user_picture::fields('u'); + $params = array( + 'userid' => $USER->id, + 'query' => "%$searchtext%" + ); + + if (empty($exceptions)) { + $exceptions = array(); + } else if (!empty($exceptions) && is_string($exceptions)) { + $exceptions = explode(',', $exceptions); + } + + // Ignore self and guest account. + $exceptions[] = $USER->id; + $exceptions[] = $CFG->siteguest; + + // Exclude exceptions from the search result. + list($except, $params_except) = $DB->get_in_or_equal($exceptions, SQL_PARAMS_NAMED, 'param', false); + $except = ' AND u.id ' . $except; + $params = array_merge($params_except, $params); if (in_array(SITEID, $courseids)) { // Search on site level. - $params = array($USER->id, "%$searchtext%"); return $DB->get_records_sql("SELECT $ufields, mc.id as contactlistid, mc.blocked FROM {user} u LEFT JOIN {message_contacts} mc - ON mc.contactid = u.id AND mc.userid = ? + ON mc.contactid = u.id AND mc.userid = :userid WHERE u.deleted = '0' AND u.confirmed = '1' - AND (".$DB->sql_like($fullname, '?', false).") + AND (".$DB->sql_like($fullname, ':query', false).") $except $order", $params); } else { // Search in courses. - $params = array($USER->id, "%$searchtext%"); // Getting the context IDs or each course. $contextids = array(); @@ -1517,7 +1528,7 @@ function message_search_users($courseids, $searchtext, $sort='', $exceptions='') $context = context_course::instance($courseid); $contextids = array_merge($contextids, $context->get_parent_context_ids(true)); } - list($contextwhere, $contextparams) = $DB->get_in_or_equal(array_unique($contextids)); + list($contextwhere, $contextparams) = $DB->get_in_or_equal(array_unique($contextids), SQL_PARAMS_NAMED, 'context'); $params = array_merge($params, $contextparams); // Everyone who has a role assignment in this course or higher. @@ -1526,9 +1537,9 @@ function message_search_users($courseids, $searchtext, $sort='', $exceptions='') FROM {user} u JOIN {role_assignments} ra ON ra.userid = u.id LEFT JOIN {message_contacts} mc - ON mc.contactid = u.id AND mc.userid = ? + ON mc.contactid = u.id AND mc.userid = :userid WHERE u.deleted = '0' AND u.confirmed = '1' - AND (".$DB->sql_like($fullname, '?', false).") + AND (".$DB->sql_like($fullname, ':query', false).") AND ra.contextid $contextwhere $except $order", $params); diff --git a/message/tests/externallib_test.php b/message/tests/externallib_test.php index 983476987c0..83f9f6cd074 100644 --- a/message/tests/externallib_test.php +++ b/message/tests/externallib_test.php @@ -351,23 +351,26 @@ class core_message_external_testcase extends externallib_advanced_testcase { $user5 = self::getDataGenerator()->create_user($user5); self::getDataGenerator()->enrol_user($user5->id, $course2->id); - // Searching for users, keep in mind that 'Admin User' and 'Guest user' can be returned for now. - // See MDL-37164 which should fix that. Once fixed, remove the +2's. $this->setUser($user1); + $results = core_message_external::search_contacts('r'); $results = external_api::clean_returnvalue(core_message_external::search_contacts_returns(), $results); - $this->assertCount(4 + 2, $results); + $this->assertCount(5, $results); // Users 2 through 5 + admin + $results = core_message_external::search_contacts('r', true); $results = external_api::clean_returnvalue(core_message_external::search_contacts_returns(), $results); $this->assertCount(2, $results); + $results = core_message_external::search_contacts('Kyle', false); $results = external_api::clean_returnvalue(core_message_external::search_contacts_returns(), $results); $this->assertCount(1, $results); $result = reset($results); $this->assertEquals($user4->id, $result['id']); + $results = core_message_external::search_contacts('y', false); $results = external_api::clean_returnvalue(core_message_external::search_contacts_returns(), $results); $this->assertCount(2, $results); + $results = core_message_external::search_contacts('y', true); $results = external_api::clean_returnvalue(core_message_external::search_contacts_returns(), $results); $this->assertCount(1, $results);