L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-36547 fix section handling in precreate_course_module()

Browse Source
This commit is contained in:
Petr Škoda
2012-11-17 09:06:12 +01:00
parent 996db2f7ac
commit 2ded89d564
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/phpunit/classes/module_generator.php
+6 -3
View File
@@ -87,13 +87,12 @@ abstract class phpunit_module_generator {
$cm->course = $courseid; $cm->course = $courseid;
$cm->module = $DB->get_field('modules', 'id', array('name'=>$modulename)); $cm->module = $DB->get_field('modules', 'id', array('name'=>$modulename));
$cm->instance = 0; $cm->instance = 0;
$cm->section = isset($options['section']) ? $options['section'] : 0;
$cm->idnumber = isset($options['idnumber']) ? $options['idnumber'] : 0; $cm->idnumber = isset($options['idnumber']) ? $options['idnumber'] : 0;
$cm->added = time(); $cm->added = time();
$columns = $DB->get_columns('course_modules'); $columns = $DB->get_columns('course_modules');
foreach ($options as $key=>$value) { foreach ($options as $key=>$value) {
if ($key === 'id' or !isset($columns[$key])) { if ($key === 'id' or !isset($columns[$key]) or $key === 'section') {
continue; continue;
} }
if (property_exists($cm, $key)) { if (property_exists($cm, $key)) {
@@ -105,7 +104,11 @@ abstract class phpunit_module_generator {
$cm->id = $DB->insert_record('course_modules', $cm); $cm->id = $DB->insert_record('course_modules', $cm);
$cm->coursemodule = $cm->id; $cm->coursemodule = $cm->id;
add_mod_to_section($cm); // add_mod_to_section() expects sectionnum, not id, crazy!
$cm->section = isset($options['section']) ? $options['section'] : 0;
$sectionid = add_mod_to_section($cm);
// Store the real section id.
$DB->set_field('course_modules', 'section', $sectionid, array('id'=>$cm->id));
return $cm->id; return $cm->id;
} }