From 2dc6ab3567d63442b4bbb9a7f2996ee2ab8917f0 Mon Sep 17 00:00:00 2001
From: Laurent David <lmedavid@gmail.com>
Date: Wed, 8 Nov 2023 12:23:23 +0100
Subject: [PATCH] MDL-79512 mod_feedback: Fix issue with drag and drop

* A teacher can not change the order of the questions in feedback
as the order is not saved.
---
 mod/feedback/yui/dragdrop/dragdrop.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mod/feedback/yui/dragdrop/dragdrop.js b/mod/feedback/yui/dragdrop/dragdrop.js
index c1cfaca3bbd..063386d6eea 100644
--- a/mod/feedback/yui/dragdrop/dragdrop.js
+++ b/mod/feedback/yui/dragdrop/dragdrop.js
@@ -171,7 +171,7 @@ YUI.add('moodle-mod_feedback-dragdrop', function(Y) {
                 var elementId;
                 var elements = [];
                 drop.all(CSS.DRAGITEM).each(function(v) {
-                    childElement = v.one('.felement').one('[id^="feedback_item_"]');
+                    childElement = v.one('.felement')?.one('[id^="feedback_item_"]');
                     if (childElement) {
                         elementId = this.get_node_id(childElement.get('id'));
                         if (elements.indexOf(elementId) == -1) {