diff --git a/mod/data/field/checkbox/field.class.php b/mod/data/field/checkbox/field.class.php index 8b7c0a65330..5b3cbf725ed 100644 --- a/mod/data/field/checkbox/field.class.php +++ b/mod/data/field/checkbox/field.class.php @@ -46,10 +46,9 @@ class data_field_checkbox extends data_field_base { if ($this->field->required) { $str .= '$nbsp;' . get_string('requiredelement', 'form'); $str .= ''; - $str .= '
'; - $str .= html_writer::img($OUTPUT->pix_url('req'), get_string('requiredelement', 'form'), + $image = html_writer::img($OUTPUT->pix_url('req'), get_string('requiredelement', 'form'), array('class' => 'req', 'title' => get_string('requiredelement', 'form'))); - $str .= '
'; + $str .= html_writer::div($image, 'inline-req'); } else { $str .= ''; } @@ -62,7 +61,7 @@ class data_field_checkbox extends data_field_base { } $str .= ''; $str .= 'field->description).'">'; + $str = '
'; $dayselector = html_writer::select_time('days', 'field_'.$this->field->id.'_day', $content); $monthselector = html_writer::select_time('months', 'field_'.$this->field->id.'_month', $content); $yearselector = html_writer::select_time('years', 'field_'.$this->field->id.'_year', $content); diff --git a/mod/data/field/file/field.class.php b/mod/data/field/file/field.class.php index b1cee2445ba..22c275d366d 100644 --- a/mod/data/field/file/field.class.php +++ b/mod/data/field/file/field.class.php @@ -73,7 +73,7 @@ class data_field_file extends data_field_base { $html .= ' ' . get_string('requiredelement', 'form') . ''; $image = html_writer::img($OUTPUT->pix_url('req'), get_string('requiredelement', 'form'), array('class' => 'req', 'title' => get_string('requiredelement', 'form'))); - $html .= html_writer::div($image); + $html .= html_writer::div($image, 'inline-req'); } else { $html .= ''; } @@ -93,7 +93,9 @@ class data_field_file extends data_field_base { // Print out file manager. $output = $PAGE->get_renderer('core', 'files'); + $html .= '
'; $html .= $output->render($fm); + $html .= '
'; $html .= ''; $html .= '
'; diff --git a/mod/data/field/latlong/field.class.php b/mod/data/field/latlong/field.class.php index d89df71bdef..0bb0221c4c7 100644 --- a/mod/data/field/latlong/field.class.php +++ b/mod/data/field/latlong/field.class.php @@ -62,14 +62,15 @@ class data_field_latlong extends data_field_base { $str = '
'; $str .= '
'.$this->field->name.''; $str .= ''; - $str .= '
'; - $str .= '°N
'; - $str .= html_writer::select($options, 'field_'.$this->field->id, $content, array(''=>get_string('menuchoose', 'data')), array('id'=>'field_'.$this->field->id)); + $str .= html_writer::select($options, 'field_'.$this->field->id, $content, array('' => get_string('menuchoose', 'data')), + array('id' => 'field_'.$this->field->id, 'class' => 'mod-data-input')); $str .= ''; diff --git a/mod/data/field/multimenu/field.class.php b/mod/data/field/multimenu/field.class.php index 75b6bc094d4..986b0d273aa 100644 --- a/mod/data/field/multimenu/field.class.php +++ b/mod/data/field/multimenu/field.class.php @@ -49,13 +49,14 @@ class data_field_multimenu extends data_field_base { $str .= ''; @@ -145,6 +146,7 @@ class data_field_textarea extends data_field_base { } $editor->use_editor($field, $options, $fpoptions); $str .= ''; + $str .= '
'; $str .= '
'; $str .= '
'; $str .= ''; + $str .= '
'; $str .= '
'; $str .= ''; return $str; diff --git a/mod/data/field/url/field.class.php b/mod/data/field/url/field.class.php index b89ecce3efb..4d22f32a693 100644 --- a/mod/data/field/url/field.class.php +++ b/mod/data/field/url/field.class.php @@ -56,27 +56,42 @@ class data_field_url extends data_field_base { $text = $content->content1; } } + + $autolinkable = !empty($this->field->param1) and empty($this->field->param2); + $str = '
'; $label = ''; - if (!empty($this->field->param1) and empty($this->field->param2)) { + if ($autolinkable) { $str .= ''; - $str .= ''; + $str .= '
'; - $str .= get_string('url','data').':'; + $str .= '' . get_string('url', 'data') . ':'; + if (!empty($image)) { + $str .= $image; + } + $str .= ''; $str .= $label; $str .= ''; $str .= '
'.get_string('text','data').':
'.get_string('text', 'data').':'; + $str .= 'field->id.'_0" id="'.$fieldid.'" value="'.s($url).'" size="60" />'; + $str .= 'repositories) > 0) { $str .= ''; } diff --git a/mod/data/lib.php b/mod/data/lib.php index 2a43b9af7ab..e7b6ccd380f 100644 --- a/mod/data/lib.php +++ b/mod/data/lib.php @@ -290,11 +290,12 @@ class data_field_base { // Base class for Database Field Types (see field/*/ $str = '
'; $str .= ''; + $str .= 'field->id . '" value="'.s($content).'" />'; $str .= '
'; return $str; diff --git a/mod/data/styles.css b/mod/data/styles.css index 61b088302ba..58b88fca09f 100644 --- a/mod/data/styles.css +++ b/mod/data/styles.css @@ -78,3 +78,20 @@ #page-mod-data-edit .req { cursor: help; } +#page-mod-data-edit .inline-req .req { + position: absolute; +} +#page-mod-data-edit .inline-req { + text-align: left; +} +#page-mod-data-edit .mod-data-input { + margin-left: 10px; +} + +.dir-rtl#page-mod-data-edit .inline-req { + text-align: right; +} +.dir-rtl#page-mod-data-edit .mod-data-input { + margin-left: 0px; + margin-right: 10px; +}