From 2b64c315979e48a8dba000f369bf6b827583f4e4 Mon Sep 17 00:00:00 2001 From: tjhunt Date: Fri, 18 Aug 2006 22:34:25 +0000 Subject: [PATCH] Bug #6293 - Cannot regrade a question when a teacher has added a comment with a ' Stupid, wreched, datalib. Why can't datalib take care of addslashes, so the whole of the rest of the code can forget about it? That is how a database abstraction layer should work. I know, it is pointless to moan about it, but it has just cost me 3 hours, so I feel I have earned the right to moan. --- lib/questionlib.php | 2 ++ question/comment.html | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/questionlib.php b/lib/questionlib.php index 3589a5738a1..79f5788cba3 100644 --- a/lib/questionlib.php +++ b/lib/questionlib.php @@ -715,6 +715,8 @@ function save_question_session(&$question, &$state) { $session->newgraded = $state->id; $session->sumpenalty = $state->sumpenalty; $session->comment = $state->comment; + } else { + $session->comment = addslashes($session->comment); } update_record('question_sessions', $session); } diff --git a/question/comment.html b/question/comment.html index e004879f858..81f16bf6ae7 100644 --- a/question/comment.html +++ b/question/comment.html @@ -10,7 +10,7 @@ comment); + print_textarea($usehtmleditor, 15, 60, 630, 300, $prefix.'[comment]', stripslashes($state->comment)); ?>