From 2adc0dbe96d10ee9e581b0acd2d2efd91eaa9a80 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Monlla=C3=B3?= Date: Tue, 12 Nov 2019 08:28:14 +0800 Subject: [PATCH] MDL-67217 unittest: usleep and windows don't get along well --- analytics/tests/fixtures/test_analysis.php | 2 +- analytics/tests/model_test.php | 2 +- lib/tests/time_splittings_test.php | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/analytics/tests/fixtures/test_analysis.php b/analytics/tests/fixtures/test_analysis.php index 6af04d1f2ea..b4e85d2b032 100644 --- a/analytics/tests/fixtures/test_analysis.php +++ b/analytics/tests/fixtures/test_analysis.php @@ -41,7 +41,7 @@ class test_analysis extends \core_analytics\analysis { */ public function process_analysable(\core_analytics\analysable $analysable): array { // Half a second. - usleep(500000); + sleep(1); return parent::process_analysable($analysable); } } diff --git a/analytics/tests/model_test.php b/analytics/tests/model_test.php index a4c632b6685..7d24b991e6e 100644 --- a/analytics/tests/model_test.php +++ b/analytics/tests/model_test.php @@ -292,7 +292,7 @@ class analytics_model_testcase extends advanced_testcase { $this->resetAfterTest(true); - set_config('modeltimelimit', 1, 'analytics'); + set_config('modeltimelimit', 2, 'analytics'); $courses = array(); for ($i = 0; $i < 5; $i++) { diff --git a/lib/tests/time_splittings_test.php b/lib/tests/time_splittings_test.php index 6394a3ed51c..613d8c25f4e 100644 --- a/lib/tests/time_splittings_test.php +++ b/lib/tests/time_splittings_test.php @@ -286,7 +286,7 @@ class core_analytics_time_splittings_testcase extends advanced_testcase { $mostrecentrange = reset($mostrecentrange); // We wait for the next range to be added. - usleep(1000000); + sleep(1); // We set the analysable again so the time ranges are recalculated. $seconds->set_analysable($analysable); @@ -309,7 +309,7 @@ class core_analytics_time_splittings_testcase extends advanced_testcase { $mostrecentrange = reset($mostrecentrange); // We wait for the next range to be added. - usleep(1000000); + sleep(1); $seconds->set_analysable($analysable); $nnewranges = $seconds->get_all_ranges();