From 583281c7e65feed42733ff2f40da132c40895037 Mon Sep 17 00:00:00 2001 From: Zig Tan Date: Wed, 4 Apr 2018 16:35:15 +0800 Subject: [PATCH] MDL-60726 assign: Fix assign submission confirmation alignment --- mod/assign/lang/en/assign.php | 1 + mod/assign/locallib.php | 6 +++++- mod/assign/renderer.php | 5 +---- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/mod/assign/lang/en/assign.php b/mod/assign/lang/en/assign.php index 23628bd8b82..482fbd2507d 100644 --- a/mod/assign/lang/en/assign.php +++ b/mod/assign/lang/en/assign.php @@ -118,6 +118,7 @@ $string['completionsubmit'] = 'Student must submit to this activity to complete $string['conversionexception'] = 'Could not convert assignment. Exception was: {$a}.'; $string['configshowrecentsubmissions'] = 'Everyone can see notifications of submissions in recent activity reports.'; $string['confirmsubmission'] = 'Are you sure you want to submit your work for grading? You will not be able to make any more changes.'; +$string['confirmsubmissionheading'] = 'Confirm submission'; $string['confirmbatchgradingoperation'] = 'Are you sure you want to {$a->operation} for {$a->count} students?'; $string['couldnotconvertgrade'] = 'Could not convert assignment grade for user {$a}.'; $string['couldnotconvertsubmission'] = 'Could not convert assignment submission for user {$a}.'; diff --git a/mod/assign/locallib.php b/mod/assign/locallib.php index 2ba5dc908b5..3e9fcb6a9b7 100644 --- a/mod/assign/locallib.php +++ b/mod/assign/locallib.php @@ -4775,7 +4775,11 @@ class assign { $data)); } $o = ''; - $o .= $this->get_renderer()->header(); + $o .= $this->get_renderer()->render(new assign_header($this->get_instance(), + $this->get_context(), + $this->show_intro(), + $this->get_course_module()->id, + get_string('confirmsubmissionheading', 'assign'))); $submitforgradingpage = new assign_submit_for_grading_page($notifications, $this->get_course_module()->id, $mform); diff --git a/mod/assign/renderer.php b/mod/assign/renderer.php index 3d9bde8a385..0163d528d7c 100644 --- a/mod/assign/renderer.php +++ b/mod/assign/renderer.php @@ -178,8 +178,7 @@ class mod_assign_renderer extends plugin_renderer_base { $o = ''; $o .= $this->output->container_start('submitforgrading'); - $o .= $this->output->heading(get_string('submitassignment', 'assign'), 3); - $o .= $this->output->spacer(array('height'=>30)); + $o .= $this->output->heading(get_string('confirmsubmissionheading', 'assign'), 3); $cancelurl = new moodle_url('/mod/assign/view.php', array('id' => $page->coursemoduleid)); if (count($page->notifications)) { @@ -194,9 +193,7 @@ class mod_assign_renderer extends plugin_renderer_base { $o .= $this->output->continue_button($cancelurl); } else { // All submission plugins ready - show the confirmation form. - $o .= $this->output->box_start('generalbox submitconfirm'); $o .= $this->moodleform($page->confirmform); - $o .= $this->output->box_end(); } $o .= $this->output->container_end();