From 2a5378d2c67941da6749f89fa33fe6fdc1f71d6b Mon Sep 17 00:00:00 2001 From: Eric Merrill Date: Wed, 8 Aug 2012 14:27:19 -0400 Subject: [PATCH] MDL-34793 mod_assign Fix rendering error that causes student view to break in some cases. When feedback is switched on for a assignment, and the teacher enters a grade through the gradebook, the student view would become broken, throwing a coding error. Added check that $status->grade is not empty before passing to assign_feedback_XXX::is_empty(), as that function expects an object. --- mod/assign/renderer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mod/assign/renderer.php b/mod/assign/renderer.php index 8ffe18f27e4..2c488ead617 100644 --- a/mod/assign/renderer.php +++ b/mod/assign/renderer.php @@ -324,7 +324,7 @@ class mod_assign_renderer extends plugin_renderer_base { } foreach ($status->feedbackplugins as $plugin) { - if ($plugin->is_enabled() && $plugin->is_visible() && !$plugin->is_empty($status->grade)) { + if ($plugin->is_enabled() && $plugin->is_visible() && !empty($status->grade) && !$plugin->is_empty($status->grade)) { $row = new html_table_row(); $cell1 = new html_table_cell($plugin->get_name()); $pluginfeedback = new assign_feedback_plugin_feedback($plugin, $status->grade, assign_feedback_plugin_feedback::SUMMARY, $status->coursemoduleid, $status->returnaction, $status->returnparams);