From 2a0c44b56db890ac150826c83aefd6c1d0aebf5b Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Mon, 20 Aug 2018 16:41:32 +0800 Subject: [PATCH] MDL-62660 phpunit: Remove setting of user when running adhoc tasks Before 3.4 tasks can't run as specific users. --- lib/phpunit/classes/advanced_testcase.php | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/lib/phpunit/classes/advanced_testcase.php b/lib/phpunit/classes/advanced_testcase.php index de2b4f7fb72..b0b96c68784 100644 --- a/lib/phpunit/classes/advanced_testcase.php +++ b/lib/phpunit/classes/advanced_testcase.php @@ -695,15 +695,6 @@ abstract class advanced_testcase extends base_testcase { // We do not lock the tasks. $task = \core\task\manager::adhoc_task_from_record($record); - $user = null; - if ($userid = $task->get_userid()) { - // This task has a userid specified. - $user = \core_user::get_user($userid); - - // User found. Check that they are suitable. - \core_user::require_active_user($user, true, true); - } - $task->set_lock($lock); if (!$task->is_blocking()) { $cronlock->release(); @@ -712,7 +703,6 @@ abstract class advanced_testcase extends base_testcase { } cron_prepare_core_renderer(); - $this->setUser($user); $task->execute(); \core\task\manager::adhoc_task_complete($task);