From 299aedfaf77c137654e6c7efdd366a531e4f744b Mon Sep 17 00:00:00 2001 From: Dan Marsden Date: Wed, 1 Aug 2012 09:27:37 +1200 Subject: [PATCH] MDL-34656 prevent login form from being shown inside iframe - also prevent wantsurl from being set to loadsco.php which isn't a valid page for initial load. --- mod/scorm/loadSCO.php | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/mod/scorm/loadSCO.php b/mod/scorm/loadSCO.php index 62dc8b9a06c..d5c4a94c974 100644 --- a/mod/scorm/loadSCO.php +++ b/mod/scorm/loadSCO.php @@ -49,7 +49,16 @@ if (!empty($id)) { $PAGE->set_url('/mod/scorm/loadSCO.php', array('scoid'=>$scoid, 'id'=>$cm->id)); -require_login($course, false, $cm); +if (!isloggedin()) { // Prevent login page from being shown in iframe. + // Using simple html instead of exceptions here as shown inside iframe/object. + echo html_writer::start_tag('html'); + echo html_writer::tag('head', ''); + echo html_writer::tag('body', get_string('loggedinnot')); + echo html_writer::end_tag('html'); + exit; +} + +require_login($course, false, $cm, false); // Call require_login anyway to set up globals correctly. //check if scorm closed $timenow = time();