L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-68991 core: Prevent popup blockers blocking feedback window

Browse Source 
Some browsers like Firefox are very inflexible with window.open()
and block it if it is not instantly invoked after the user click.

Also according to https://stackoverflow.com/a/6807615 it is best
practice to replace self:: with static::
This commit is contained in:
Shamim Rezaie
2020-06-10 16:10:53 +10:00
parent 4cdcd23fb2
commit 292a67aede
5 changed files with 27 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/tests/behat/userfeedback.feature
+14
View File
@@ -34,3 +34,17 @@ Feature: Gathering user feedback
And I reload the page
Then I should not see "Give feedback" in the "region-main" "region"
And I should not see "Remind me later" in the "region-main" "region"
@javascript
Scenario: Users should not see the notification after they click on the give feedback link
Given the following config values are set as admin:
| enableuserfeedback | 1 |
| userfeedback_nextreminder | 2 |
| userfeedback_remindafter | 90 |
When I log in as "admin"
And I follow "Dashboard" in the user menu
And I click on "Give feedback" "link"
And I close all opened windows
And I reload the page
Then I should not see "Give feedback" in the "region-main" "region"
And I should not see "Remind me later" in the "region-main" "region"