From 57fb48743f21ea5cca27f95015341261855ad4b8 Mon Sep 17 00:00:00 2001 From: Tim Lock Date: Mon, 6 Mar 2017 13:59:37 +1030 Subject: [PATCH] MDL-58161 user: tests: user_can_view_profile fails under certain cases --- user/tests/userlib_test.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/user/tests/userlib_test.php b/user/tests/userlib_test.php index d64d48d8bff..73e86bbdd73 100644 --- a/user/tests/userlib_test.php +++ b/user/tests/userlib_test.php @@ -581,6 +581,7 @@ class core_userliblib_testcase extends advanced_testcase { // Visitor (Not a guest user, userid=0). $CFG->forceloginforprofiles = 1; $this->setUser($user8); + $this->assertFalse(user_can_view_profile($user1)); $allroles = $DB->get_records_menu('role', array(), 'id', 'archetype, id'); // Let us test with guest user. @@ -591,7 +592,8 @@ class core_userliblib_testcase extends advanced_testcase { } // Even with cap, still guests should not be allowed in. - assign_capability('moodle/user:viewdetails', CAP_ALLOW, $allroles['guest'], context_system::instance()->id, true); + $guestrole = $DB->get_records_menu('role', array('shortname' => 'guest'), 'id', 'archetype, id'); + assign_capability('moodle/user:viewdetails', CAP_ALLOW, $guestrole['guest'], context_system::instance()->id, true); reload_all_capabilities(); foreach ($users as $user) { $this->assertFalse(user_can_view_profile($user));