MDL-77988 dml: correct logic when dropping plugin tables.

Comparison of method void return within a conditional didn't make
sense, and the aforementioned method throws an exception on error
anyway which would halt execution.
This commit is contained in:
Paul Holden
2023-08-22 21:28:42 +01:00
parent cccc00954d
commit 28e1bd37d0
2 changed files with 3 additions and 1 deletions
+2 -1
View File
@@ -370,7 +370,8 @@ function drop_plugin_tables($name, $file, $feedback=true) {
global $CFG, $DB;
// first try normal delete
if (file_exists($file) and $DB->get_manager()->delete_tables_from_xmldb_file($file)) {
if (file_exists($file)) {
$DB->get_manager()->delete_tables_from_xmldb_file($file);
return true;
}