From 28dfbe77bff6ed104d5105cc7eec8aad513bd0f0 Mon Sep 17 00:00:00 2001 From: Shamim Rezaie Date: Fri, 26 Oct 2018 22:59:17 +1100 Subject: [PATCH] MDL-63785 core_portfolio: performance improvement --- portfolio/classes/privacy/provider.php | 25 +++++++------------------ 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/portfolio/classes/privacy/provider.php b/portfolio/classes/privacy/provider.php index a1edfe26962..059294dcd4a 100644 --- a/portfolio/classes/privacy/provider.php +++ b/portfolio/classes/privacy/provider.php @@ -113,27 +113,16 @@ class provider implements return; } - $params = [ - 'contextid' => $context->id, - 'contextuser' => CONTEXT_USER, - ]; - - $sql = "SELECT ctx.instanceid as userid - FROM {portfolio_instance_user} piu - JOIN {context} ctx - ON ctx.instanceid = piu.userid - AND ctx.contextlevel = :contextuser - WHERE ctx.id = :contextid"; + $params = [$context->instanceid]; + $sql = "SELECT userid + FROM {portfolio_instance_user} + WHERE userid = ?"; $userlist->add_from_sql('userid', $sql, $params); - $sql = "SELECT ctx.instanceid as userid - FROM {portfolio_log} pl - JOIN {context} ctx - ON ctx.instanceid = pl.userid - AND ctx.contextlevel = :contextuser - WHERE ctx.id = :contextid"; - + $sql = "SELECT userid + FROM {portfolio_log} + WHERE userid = ?"; $userlist->add_from_sql('userid', $sql, $params); }