diff --git a/mod/assign/locallib.php b/mod/assign/locallib.php index 7238b7073b2..1e2488648d3 100644 --- a/mod/assign/locallib.php +++ b/mod/assign/locallib.php @@ -2760,7 +2760,9 @@ class assign { 'showquickgrading'=>false)); if ($formdata = $mform->get_data()) { set_user_preference('assign_perpage', $formdata->perpage); - set_user_preference('assign_filter', $formdata->filter); + if (isset($formdata->filter)) { + set_user_preference('assign_filter', $formdata->filter); + } } } diff --git a/mod/assign/module.js b/mod/assign/module.js index a1cbe079237..ec5e0717705 100644 --- a/mod/assign/module.js +++ b/mod/assign/module.js @@ -117,9 +117,11 @@ M.mod_assign.init_grading_options = function(Y) { Y.one('form.gradingoptionsform').submit(); }); var filterelement = Y.one('#id_filter'); - filterelement.on('change', function(e) { - Y.one('form.gradingoptionsform').submit(); - }); + if (filterelement) { + filterelement.on('change', function(e) { + Y.one('form.gradingoptionsform').submit(); + }); + } var quickgradingelement = Y.one('#id_quickgrading'); if (quickgradingelement) { quickgradingelement.on('change', function(e) { @@ -139,4 +141,4 @@ M.mod_assign.init_grade_change = function(Y) { } }); } -}; \ No newline at end of file +};