From bcf0112c368449b6b5cc14f4d9cc89997b8c8558 Mon Sep 17 00:00:00 2001 From: Tim Hunt Date: Mon, 3 Jul 2023 09:12:19 +0100 Subject: [PATCH] MDL-78622 quiz: add question query must include contextid It is logically requried and necessary for the query to use the index --- mod/quiz/locallib.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mod/quiz/locallib.php b/mod/quiz/locallib.php index 855ea61db11..6585d87a25c 100644 --- a/mod/quiz/locallib.php +++ b/mod/quiz/locallib.php @@ -2352,9 +2352,11 @@ function quiz_add_quiz_question($questionid, $quiz, $page = 0, $maxmark = null) JOIN {question_bank_entries} qbe ON qbe.id = qr.questionbankentryid WHERE slot.quizid = ? AND qr.component = ? - AND qr.questionarea = ?"; + AND qr.questionarea = ? + AND qr.usingcontextid = ?"; - $questionslots = $DB->get_records_sql($sql, [$quiz->id, 'mod_quiz', 'slot']); + $questionslots = $DB->get_records_sql($sql, [$quiz->id, 'mod_quiz', 'slot', + context_module::instance($quiz->cmid)->id]); $currententry = get_question_bank_entry($questionid);