From 0005474c9cde82a06e3e75225fba02a98db91273 Mon Sep 17 00:00:00 2001 From: Dan Marsden Date: Thu, 1 Jul 2021 13:54:26 +1200 Subject: [PATCH] MDL-72052 assign: - cache assign class. --- mod/assign/submission/comments/lib.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/mod/assign/submission/comments/lib.php b/mod/assign/submission/comments/lib.php index 71caab65319..fe6cb76997b 100644 --- a/mod/assign/submission/comments/lib.php +++ b/mod/assign/submission/comments/lib.php @@ -43,7 +43,10 @@ function assignsubmission_comments_comment_validate(stdClass $options) { $context = $options->context; require_once($CFG->dirroot . '/mod/assign/locallib.php'); - $assignment = new assign($context, null, null); + static $assignment = null; + if (is_null($assignment) || $assignment->get_context() != $context) { + $assignment = new assign($context, null, null); + } if ($assignment->get_instance()->id != $submission->assignment) { throw new comment_exception('invalidcontext'); @@ -71,7 +74,10 @@ function assignsubmission_comments_comment_permissions(stdClass $options) { $context = $options->context; require_once($CFG->dirroot . '/mod/assign/locallib.php'); - $assignment = new assign($context, null, null); + static $assignment = null; + if (is_null($assignment) || $assignment->get_context() != $context) { + $assignment = new assign($context, null, null); + } if ($assignment->get_instance()->id != $submission->assignment) { throw new comment_exception('invalidcontext');