From 26bc714f1f8831cdb88155e6b4fee4876becee27 Mon Sep 17 00:00:00 2001 From: Andrew Davis Date: Tue, 27 Nov 2012 10:04:59 +0800 Subject: [PATCH] MDL-36761 core_grade:shifted a call to count() out of a loop --- lib/grade/grade_category.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/grade/grade_category.php b/lib/grade/grade_category.php index c428adf9125..813a8943d39 100644 --- a/lib/grade/grade_category.php +++ b/lib/grade/grade_category.php @@ -892,7 +892,9 @@ class grade_category extends grade_object { $droppedsomething = false; $grade_keys = array_keys($grade_values); - if (count($grade_keys) === 0) { + $gradekeycount = count($grade_keys); + + if ($gradekeycount === 0) { //We've dropped all grade items break; } @@ -916,7 +918,7 @@ class grade_category extends grade_object { } $i = 1; - while ($originalindex+$i < count($grade_keys)) { + while ($originalindex + $i < $gradekeycount) { $possibleitemid = $grade_keys[$originalindex+$i]; $i++;