From 26756d9c6fb7210654ccaa3d2f18399720f35239 Mon Sep 17 00:00:00 2001 From: Tim Hunt Date: Wed, 11 Jan 2012 10:09:30 +0000 Subject: [PATCH] MDL-30635 quiz cron: fixup - enable in version.php & fn name quiz_statistics_cron --- mod/quiz/report/statistics/lib.php | 28 +++++++++++----------------- mod/quiz/version.php | 4 ++-- 2 files changed, 13 insertions(+), 19 deletions(-) diff --git a/mod/quiz/report/statistics/lib.php b/mod/quiz/report/statistics/lib.php index efa3ed791eb..0f3e262721b 100644 --- a/mod/quiz/report/statistics/lib.php +++ b/mod/quiz/report/statistics/lib.php @@ -49,14 +49,14 @@ function quiz_statistics_questiontext_preview_pluginfile($context, $questionid, } /** -* Quiz statistics report cron code. Deletes cached data more than a certain age. -*/ -function quiz_report_statistics_cron() { + * Quiz statistics report cron code. Deletes cached data more than a certain age. + */ +function quiz_statistics_cron() { global $DB; $expiretime = time() - 5*HOURSECS; - $todelete = $DB->get_records_select_menu('quiz_statistics', 'timemodified < ?', - array($expiretime), '', 'id, 1'); + $todelete = $DB->get_records_select_menu('quiz_statistics', + 'timemodified < ?', array($expiretime), '', 'id, 1'); if (!$todelete) { return true; @@ -64,20 +64,14 @@ function quiz_report_statistics_cron() { list($todeletesql, $todeleteparams) = $DB->get_in_or_equal(array_keys($todelete)); - if (!$DB->delete_records_select('quiz_question_statistics', - 'quizstatisticsid ' . $todeletesql, $todeleteparams)) { - mtrace('Error deleting out of date quiz_question_statistics records.'); - } + $DB->delete_records_select('quiz_question_statistics', + 'quizstatisticsid ' . $todeletesql, $todeleteparams); - if (!$DB->delete_records_select('quiz_question_response_stats', - 'quizstatisticsid ' . $todeletesql, $todeleteparams)) { - mtrace('Error deleting out of date quiz_question_response_stats records.'); - } + $DB->delete_records_select('quiz_question_response_stats', + 'quizstatisticsid ' . $todeletesql, $todeleteparams); - if (!$DB->delete_records_select('quiz_statistics', - 'id ' . $todeletesql, $todeleteparams)) { - mtrace('Error deleting out of date quiz_statistics records.'); - } + $DB->delete_records_select('quiz_statistics', + 'id ' . $todeletesql, $todeleteparams); return true; } diff --git a/mod/quiz/version.php b/mod/quiz/version.php index 39f8bfd3606..33124f09eca 100644 --- a/mod/quiz/version.php +++ b/mod/quiz/version.php @@ -25,7 +25,7 @@ defined('MOODLE_INTERNAL') || die(); -$module->version = 2011120701; // The current module version (Date: YYYYMMDDXX) +$module->version = 2011120702; // The current module version (Date: YYYYMMDDXX) $module->requires = 2011112900; // Requires this Moodle version $module->component = 'mod_quiz'; // Full name of the plugin (used for diagnostics) -$module->cron = 0; +$module->cron = 60;