From f7a4eefd9b47ce6b87660ac7edaee21001926680 Mon Sep 17 00:00:00 2001 From: Paul Holden Date: Thu, 20 May 2021 20:39:38 +0100 Subject: [PATCH] MDL-71693 admin: set default for debugdisplay to off. The previous default value for this config was based on the PHP ini file `display_error` property (6349a3ba). However we override this propertly during page setup (25338300) according to the value of the configuration itself. This had the effect of always setting the default value for this config to it's current value. --- admin/settings/development.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/admin/settings/development.php b/admin/settings/development.php index 3844fe9a01f..88d6df729c3 100644 --- a/admin/settings/development.php +++ b/admin/settings/development.php @@ -38,7 +38,8 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page // "debugging" settingpage $temp = new admin_settingpage('debugging', new lang_string('debugging', 'admin')); $temp->add(new admin_setting_special_debug()); - $temp->add(new admin_setting_configcheckbox('debugdisplay', new lang_string('debugdisplay', 'admin'), new lang_string('configdebugdisplay', 'admin'), ini_get_bool('display_errors'))); + $temp->add(new admin_setting_configcheckbox('debugdisplay', new lang_string('debugdisplay', 'admin'), + new lang_string('configdebugdisplay', 'admin'), 0)); $temp->add(new admin_setting_configcheckbox('perfdebug', new lang_string('perfdebug', 'admin'), new lang_string('configperfdebug', 'admin'), '7', '15', '7')); $temp->add(new admin_setting_configcheckbox('debugstringids', new lang_string('debugstringids', 'admin'), new lang_string('debugstringids_desc', 'admin'), 0)); $temp->add(new admin_setting_configselect('debugsqltrace',