From 24f824b92485d468bb1e5b9233e07413069c1069 Mon Sep 17 00:00:00 2001 From: Marina Glancy Date: Tue, 3 Sep 2013 13:45:00 +1000 Subject: [PATCH] MDL-41517 Do not call fix_course_sortorder unnecessarily Thanks to Thomas Worthington --- course/lib.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/course/lib.php b/course/lib.php index a0b5f5a3f4a..52462a266a3 100644 --- a/course/lib.php +++ b/course/lib.php @@ -2408,7 +2408,10 @@ function update_course($data, $editoroptions = NULL) { $context->update_moved($newparent); } - fix_course_sortorder(); + if ($movecat || (isset($data->sortorder) && $oldcourse->sortorder != $data->sortorder)) { + fix_course_sortorder(); + } + // purge appropriate caches in case fix_course_sortorder() did not change anything cache_helper::purge_by_event('changesincourse'); if ($changesincoursecat) {