From 24eae720fa9435a135a44b271b4935379163a2c3 Mon Sep 17 00:00:00 2001 From: Olivier Piton Date: Thu, 13 Dec 2018 12:02:23 +0800 Subject: [PATCH] MDL-61535 report_security: SQL Perf improvement --- report/security/locallib.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/report/security/locallib.php b/report/security/locallib.php index acbd1483133..e696b83281d 100644 --- a/report/security/locallib.php +++ b/report/security/locallib.php @@ -466,7 +466,7 @@ function report_security_check_riskxss($detailed=false) { $params = array('capallow'=>CAP_ALLOW); - $sqlfrom = "FROM (SELECT rcx.* + $sqlfrom = "FROM (SELECT DISTINCT rcx.contextid, rcx.roleid FROM {role_capabilities} rcx JOIN {capabilities} cap ON (cap.name = rcx.capability AND ".$DB->sql_bitand('cap.riskbitmask', RISK_XSS)." <> 0) WHERE rcx.permission = :capallow) rc, @@ -755,7 +755,7 @@ function report_security_check_riskbackup($detailed=false) { $params = array('capability'=>'moodle/backup:userinfo', 'permission'=>CAP_ALLOW, 'context1'=>CONTEXT_COURSE, 'context2'=>CONTEXT_COURSE); $sqluserinfo = " - FROM (SELECT rcx.* + FROM (SELECT DISTINCT rcx.contextid, rcx.roleid FROM {role_capabilities} rcx WHERE rcx.permission = :permission AND rcx.capability = :capability) rc, {context} c,